Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VariableSpec to use StateItemAspect #3267

Open
tclune opened this issue Dec 23, 2024 · 0 comments
Open

Refactor VariableSpec to use StateItemAspect #3267

tclune opened this issue Dec 23, 2024 · 0 comments
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Dec 23, 2024

Variable specs can now be thought of as a collection of orthogonal aspects. It mostly consists of constructors that accept user-level objects and binds them into aspects.

There will be significant overlap between AspectCollection and VariableSpec at first. Possibly these will be merged now or in a later refactoring. There will also be lots of overlap between VariableSpec and StateItemSpec concrete subclasses as well. Possibly these become extensions of VariableSpec or AspectCollection in the end.

StateItem subclasses are still needed for constructing payloads though at least for now.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related labels Dec 23, 2024
tclune added a commit that referenced this issue Jan 3, 2025
@tclune
Merge pull request #3271 from GEOS-ESM/feature/tclune/#3267-refactor-…
7f99e3a 
…variable-spec

Fixes #3267 refactor variable spec
tclune added a commit that referenced this issue Jan 10, 2025
@tclune
Fixes #3267 - Implementation of VerticalGridAspect.
feef68a 
- Adaptor mechanism now deleted.
tclune added a commit that referenced this issue Jan 12, 2025
@tclune
Merge branch 'release/MAPL-v3' into feature/tclune/#3267-refactor-var…
bddd1d6 
…iable-spec
tclune added a commit that referenced this issue Jan 12, 2025
@tclune
Merge pull request #3301 from GEOS-ESM/feature/tclune/#3267-refactor-…
5207c45 
…variable-spec

Fixes #3267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tclune