Correct design for producer/consumer in StateItemExtension #3264
Assignees
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
📈 MAPL3
MAPL 3 Related
🛠️ Refactor
This is code refactoring
Comments
tclune
added
0 Diff
tclune
added a commit
that referenced
this issue
Dec 23, 2024
StateItemExtensions now own the consumers rather than the producers. This change was motivated by the fact that imports and "final" extensions need to share the producer, whereas consumers always associated with a unique item - the one that generates the extension. Various other interfaces needed to be updated. Primarily many references to GriddedComponentDriver now need to be refrences to the abstract parent: ComponentDriver, which is actually a good thing in and of itself.
tclune
added a commit
that referenced
this issue
Dec 23, 2024
tclune
added a commit
that referenced
this issue
Dec 23, 2024
…consumer-swap Feature/tclune/#3264 producer consumer swap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently extensions have an allocatable "producer" and a Map of pointers to "consumers". This is convenient because it allows the procedure that creates a new spec and a producer to immediately bind them into a new extension, but ultimately the ownership is wrong.
The main problem is that it import specs need to share the producer with the "ultimate" extension, and as an ALLOCATABLE they cannot share. But if we reverse the design, to have an extension have a map of (allocatable) consumers and only a pointer to the producer, this problem is fixed.
The fix will also allow a cleaner implementation for the loops that identify all import and export couplers for a given component:
The text was updated successfully, but these errors were encountered: