-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DSOs? #70
Comments
Be my guest to implement DSOs, wthatever that is... I am assuming this is a cmake level update. |
@tclune Is this something to be done now? |
@amdasilva I think we can do it with relative ease at any point. Relatively simple CMake surgery. @atrayano did recently do something like this with MIT ocean, and got different answers which gave us pause; so we'd best double check that there are no surprises with GOCART. I can add it to the backlog for @weiyuan-jiang |
There seems already no dependency of gorcar2g on its children GOCART/ESMF/GOCART2G_GridComp/CMakeLists.txt Lines 24 to 29 in 4c94179
|
@tclune , what is the specific issue here? |
The use statements here should go away: GOCART/ESMF/GOCART2G_GridComp/GOCART2G_GridCompMod.F90 Lines 20 to 24 in 4c94179
Need to use add child via DSO interface. |
Note that the harder part is likely to be dealing with run-time path issues. You'll need to work with @mathomp4 to have a short term and long term solution for that. |
During the development of GOCART2G, we updated the rest of the GCM to use DSOs and thereby eliminated compile time dependencies between components. GOCART2G has not been updated in that manner.
Should this be done before v2.0.0 or after?
The text was updated successfully, but these errors were encountered: