-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v12: Fixes #653. Update default ocean to CS for C90+ #661
v12: Fixes #653. Update default ocean to CS for C90+ #661
Conversation
@mathomp4 Reynolds ocean files start Jan 1971 |
@mathomp4 yes, please add the default in gmichem_setup. BTW, do you know the resolution of the CS OSTIA data? |
@mmanyin The same as the atmosphere you are running. I believe is is Ostia data remapped to the native resolution of the atmosphere. That way, there is no regridding done when you run since the atmosphere and ocean are on the same grid. Very useful at high-res. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GMI setup script looks good, thanks
I suppose one question for @sdrabenh would be: Should I backport this to v11? As @weiyuan-jiang said, even the v11 remap_utils script has the "CS for C90+" for default, so part of me thinks v11 should get this as well... |
Closes #653
This PR is an attempt to set the default ocean in the setup scripts (minus
gmichem_setup
which has a complex ocean selection) to choose Reynolds at C12 to C48 and then CS ocean at C90+.I've also added a comment that the Reynolds ocean ends in 2022. I didn't add this comment to
gmichem_setup
since it's echo for ocean does a different thing. @mmanyin do you know when Reynolds starts? If so, I can update the script with the right range for Reynolds.Keeping draft until I can test.
cc @sshakoor1 as he might as well do something similar in his Python variant.