Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12: Fixes #653. Update default ocean to CS for C90+ #661

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 7, 2024

Closes #653

This PR is an attempt to set the default ocean in the setup scripts (minus gmichem_setup which has a complex ocean selection) to choose Reynolds at C12 to C48 and then CS ocean at C90+.

I've also added a comment that the Reynolds ocean ends in 2022. I didn't add this comment to gmichem_setup since it's echo for ocean does a different thing. @mmanyin do you know when Reynolds starts? If so, I can update the script with the right range for Reynolds.

Keeping draft until I can test.

cc @sshakoor1 as he might as well do something similar in his Python variant.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 7, 2024
@mathomp4 mathomp4 self-assigned this Nov 7, 2024
@mmanyin
Copy link
Contributor

mmanyin commented Nov 7, 2024

@mathomp4 Reynolds ocean files start Jan 1971

@mathomp4
Copy link
Member Author

mathomp4 commented Nov 7, 2024

@mathomp4 Reynolds ocean files start Jan 1971

@mmanyin I will add that in. Also, would you like me to do the C90+ defaults to CS ocean for gmichem_setup as well? It wouldn't be hard, just didn't know if that's what you'd prefer for GMI or not!

@mmanyin
Copy link
Contributor

mmanyin commented Nov 7, 2024

@mmanyin I will add that in. Also, would you like me to do the C90+ defaults to CS ocean for gmichem_setup as well? It wouldn't be hard, just didn't know if that's what you'd prefer for GMI or not!

@mathomp4 yes, please add the default in gmichem_setup. BTW, do you know the resolution of the CS OSTIA data?

@mathomp4
Copy link
Member Author

mathomp4 commented Nov 7, 2024

@mathomp4 yes, please add the default in gmichem_setup. BTW, do you know the resolution of the CS OSTIA data?

@mmanyin The same as the atmosphere you are running. I believe is is Ostia data remapped to the native resolution of the atmosphere. That way, there is no regridding done when you run since the atmosphere and ocean are on the same grid. Very useful at high-res.

@mathomp4 mathomp4 marked this pull request as ready for review November 7, 2024 19:27
@mathomp4 mathomp4 requested a review from a team as a code owner November 7, 2024 19:27
@mathomp4 mathomp4 requested a review from mmanyin November 7, 2024 19:32
@mathomp4 mathomp4 linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GMI setup script looks good, thanks

@mathomp4 mathomp4 changed the title Fixes #653. Update default ocean to CS for C90+ v12: Fixes #653. Update default ocean to CS for C90+ Nov 8, 2024
@mathomp4
Copy link
Member Author

mathomp4 commented Nov 8, 2024

I suppose one question for @sdrabenh would be: Should I backport this to v11?

As @weiyuan-jiang said, even the v11 remap_utils script has the "CS for C90+" for default, so part of me thinks v11 should get this as well...

@sdrabenh sdrabenh merged commit 6a39dd4 into feature/sdrabenh/gcm_v12 Dec 13, 2024
12 checks passed
@mathomp4 mathomp4 deleted the feature/mathomp4/653-update-default-ocean-v12 branch December 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default data ocean for v12?
3 participants