Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended IDs LSB Truncated. #203

Open
8bitgeek opened this issue Jun 1, 2020 · 10 comments
Open

Extended IDs LSB Truncated. #203

8bitgeek opened this issue Jun 1, 2020 · 10 comments

Comments

@8bitgeek
Copy link

8bitgeek commented Jun 1, 2020

I'm having an issue with the LSB being truncated. As you can see all the IDs have LSB 0x00 when in fact many of them should not be zero. Is there something I need to be aware of?

CANdevStudio-ExtendedIDsTruncated

@sangngocle
Copy link

I have the same issue with J1939 ID, checking around in the code but stand still :(

@rkollataj
Copy link
Member

@8bitgeek @SNL5943 Could you share DBC file you are loading?

@8bitgeek
Copy link
Author

8bitgeek commented Jun 5, 2020

extended-ids.dbc.zip

@rkollataj
Copy link
Member

rkollataj commented Jun 5, 2020

It looks like a problem with CANdb (3rdParty/CANdb submodule). I believe that below patch will solve the problem. I need to make sure with @btaczala (CANdb maintainer) if that's correct fix. @8bitgeek @SNL5943 Give it a try and let me know.

https://gist.github.com/rkollataj/28865272b1ed7791f8817484bad458c7

@btaczala
Copy link
Collaborator

btaczala commented Jun 6, 2020

@8bitgeek can I include dbc file into DBC repo (for testing purposes)?

@sangngocle
Copy link

sangngocle commented Jun 8, 2020

@rkollataj : Yes, the issue is solved by your patch. Thanks!!

@8bitgeek
Copy link
Author

The extended ids appear to be fixed.

However, now I have this issue where the CanSignalSender Value ranges are incorrect. Many of them read "min: 0 max: 0" which is incorrect.

candevstudio-wrong-ranges
candevstudio-wrong-ranges1

@rkollataj
Copy link
Member

You're right. For CANParkBrakeStatus it should be min 0 and max 3. Was it like that before the patch or patch has broken this?

@8bitgeek
Copy link
Author

I worked before. I appears to me that the patch broke this.

@jogo-
Copy link
Contributor

jogo- commented Jul 3, 2021

@8bitgeek @btaczala Have you tried with latest v1.2.2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants