Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private OpenFlow/FOAM RSpecs should not be able to be made public #800

Open
MarshallBrinn opened this issue May 21, 2015 · 6 comments
Open

Comments

@MarshallBrinn
Copy link
Contributor

We agreed that experimenters should be allowed to upload FOAM/OpenFlow RSpecs to the Portal as 'private' (i.e. only that user can see them). But the portal allows changing private RSpecs to public ones, thus allowing these RSpecs to be used publicly.

We should preclude this ability, at least for FOAM/OpenFlow RSpecs.

Imported from trac ticket #800, created by mbrinn on 09-17-2013 at 15:58, last modified: 09-19-2013 at 14:12
CCing: hpd@...

@ahelsing
Copy link
Member

Really? It seems to me like it'd be useful to be able to show other people my rspecs; even if they can't use them as-is, they could copy them and upload their own copy... But not if they can't even see them.

Trac comment by jbs on 09-17-2013 at 16:13

@innnkkki
Copy link

I think the problem is that by making OF rspecs public and merging them in the same list as all the other rspecs it can potentially get confusing for naive experimenters. So it would be ideal if:
i. OF rspecs are private by default
ii. the user can make them public if they choose to
iii. OF rspecs are on a separate list than the rest of the rspecs to avoid confusion

I think Heidi and I are in agreement on this one if all three of the above are true.

If (iii) does not happen then I think there are two ways moving forward:
(1) force all OF rspecs to always be private
(2) allow them to be public if a user choses to and hope that not many people will make their rspecs public so this will not be an issue.

I will also bring this up with experimenter group to see what they think as well and update the ticket.

Trac comment by nriga (github user: innnkkki) on 09-17-2013 at 17:12

@seledwards
Copy link
Contributor

I agree with Niky's three part plan.

Trac comment by sedwards (github user: seledwards) on 09-17-2013 at 17:14

@ahelsing
Copy link
Member

"You can make them public but they're sorted or marked or otherwise obviously different" sounds all right to me too.

Trac comment by jbs on 09-18-2013 at 11:33

@innnkkki
Copy link

Talked to Sarah and Vic and the conclusion was that anyway currently there is no guarantees that any of the listed rspcs would
work with any of the AMs (EG-specific won't work with IG etc) so letting them be public is good for us, as long as OF AMs are harder to get to.

Trac comment by nriga (github user: innnkkki) on 09-19-2013 at 10:31

@ahelsing
Copy link
Member

Currently we do Niky's (i) and (ii) and not (iii). From her secondary list, be believe in (2) - that people won't make their RSpecs public very much.
We have in mind making OF AMs harder to get to, as we discussed

Given this -

  • Should we change the summary for this ticket to be making OF RSpecs on a separate list?

Trac comment by ahelsing on 09-19-2013 at 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants