Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #8

Open
da-ksh-esh opened this issue Sep 29, 2024 · 1 comment
Open

Update index.html #8

da-ksh-esh opened this issue Sep 29, 2024 · 1 comment

Comments

@da-ksh-esh
Copy link

Identified Issues:

Missing closing tags:
In the .back section of the .flip div, there are incomplete or missing closing tags, which will cause rendering issues.

Repetitive SVG elements:
The same SVG logo is repeated twice. This creates unnecessary duplication and can be extracted for reuse.

Semantic HTML issues:
The is invalid. The correct type should be number for input fields.
Missing name attributes for form inputs, which are needed for proper form submission.

Accessibility issues:
Inputs lack proper aria-labels or for attributes, making the form less accessible.

Form field validation:
No client-side validation is implemented (e.g., for the card number and expiration date).

Year selection options:
The expiration year options are outdated (e.g., from 2016–2025), making the form less practical for current use.

Redundant CSS styling inside SVG:
The style="enable-background:new 0 0 47.834 47.834;" inside the SVG tag is not necessary in this context.

Non-semantic button content:
Instead of using an icon , a more meaningful text or additional labeling should be added to improve accessibility.

@Soyvor
Copy link
Contributor

Soyvor commented Sep 29, 2024

Ok solve the issue and move forward with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants