Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

typeof output gets coerced to bool #246

Open
Rudxain opened this issue Jun 15, 2022 · 1 comment · May be fixed by #232
Open

typeof output gets coerced to bool #246

Rudxain opened this issue Jun 15, 2022 · 1 comment · May be fixed by #232

Comments

@Rudxain
Copy link
Contributor

Rudxain commented Jun 15, 2022

The parseIconPlist script is checking the truthiness value of typeof at line 23. Is it supposed to be typeof fileData[innerKey] == "string"? Or is the expression not needed there?
@GDColon
Copy link
Owner

GDColon commented Jun 16, 2022

LMAO honestly I have no idea, probably meant to be string but considering the script works fine as is it can probably just be removed entirely

@Rudxain Rudxain linked a pull request Jun 16, 2022 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A lot of refactoring, and etc Rudxain/GDBrowser
2 participants
@GDColon @Rudxain