From 03b9dde650fee3817ea7c5890f7f4c23add7def4 Mon Sep 17 00:00:00 2001 From: AViewFromTheTop <87103914+AViewFromTheTop@users.noreply.github.com> Date: Mon, 3 Feb 2025 20:29:04 -0500 Subject: [PATCH] Mesoglea features no longer carve "fake caves," instead only generating in areas with Water or Air nearby. --- CHANGELOG.md | 1 + .../blue_mesoglea_path.json | 6 ++--- .../purple_mesoglea_path.json | 6 ++--- .../feature/configured/WWCaveConfigured.java | 22 +++++++++---------- 4 files changed, 18 insertions(+), 17 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 45da355ef6..3fa7836ed3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -82,6 +82,7 @@ hi - Clovers generate in biomes in the `wilderwild:feature/has_clovers` tag. - Fixed Wilder Wild's blocks having incorrect flammability values. - Removed shallow pools from the Oasis biome as they weren't visually pleasing. +- Mesoglea features no longer carve "fake caves," instead only generating in areas with Water or Air nearby. # Music - Added three new tracks by Willow/pictochats_. diff --git a/src/main/generated/data/wilderwild/worldgen/configured_feature/blue_mesoglea_path.json b/src/main/generated/data/wilderwild/worldgen/configured_feature/blue_mesoglea_path.json index c12adeb776..ed674fed19 100644 --- a/src/main/generated/data/wilderwild/worldgen/configured_feature/blue_mesoglea_path.json +++ b/src/main/generated/data/wilderwild/worldgen/configured_feature/blue_mesoglea_path.json @@ -1,14 +1,14 @@ { - "type": "frozenlib:noise_path_feature", + "type": "frozenlib:requires_air_or_water_in_area_noise_path_feature", "config": { + "air_search_distance": 2, "is_3d": true, "max_threshold": 0.5875, "min_threshold": 0.5125, "noise": 1, "noise_scale": 0.025, - "only_place_when_exposed": false, "placement_chance": 1.0, - "radius": 14, + "radius": 12, "replaceable_blocks": "#wilderwild:feature/mesoglea_path_replaceable", "scale_y": true, "state": { diff --git a/src/main/generated/data/wilderwild/worldgen/configured_feature/purple_mesoglea_path.json b/src/main/generated/data/wilderwild/worldgen/configured_feature/purple_mesoglea_path.json index cf4b3472ca..c2f1e6dc8f 100644 --- a/src/main/generated/data/wilderwild/worldgen/configured_feature/purple_mesoglea_path.json +++ b/src/main/generated/data/wilderwild/worldgen/configured_feature/purple_mesoglea_path.json @@ -1,14 +1,14 @@ { - "type": "frozenlib:noise_path_feature", + "type": "frozenlib:requires_air_or_water_in_area_noise_path_feature", "config": { + "air_search_distance": 2, "is_3d": true, "max_threshold": -0.5125, "min_threshold": -0.5875, "noise": 1, "noise_scale": 0.025, - "only_place_when_exposed": false, "placement_chance": 1.0, - "radius": 14, + "radius": 12, "replaceable_blocks": "#wilderwild:feature/mesoglea_path_replaceable", "scale_y": true, "state": { diff --git a/src/main/java/net/frozenblock/wilderwild/worldgen/feature/configured/WWCaveConfigured.java b/src/main/java/net/frozenblock/wilderwild/worldgen/feature/configured/WWCaveConfigured.java index bbedb07d16..f5c046025c 100644 --- a/src/main/java/net/frozenblock/wilderwild/worldgen/feature/configured/WWCaveConfigured.java +++ b/src/main/java/net/frozenblock/wilderwild/worldgen/feature/configured/WWCaveConfigured.java @@ -21,6 +21,7 @@ import java.util.List; import net.frozenblock.lib.worldgen.feature.api.FrozenLibConfiguredFeature; import net.frozenblock.lib.worldgen.feature.api.FrozenLibFeatures; +import net.frozenblock.lib.worldgen.feature.api.features.config.AirOrWaterInAreaPathFeatureConfig; import net.frozenblock.lib.worldgen.feature.api.features.config.ColumnFeatureConfig; import net.frozenblock.lib.worldgen.feature.api.features.config.ComboFeatureConfig; import net.frozenblock.lib.worldgen.feature.api.features.config.FadingDiskTagFeatureConfig; @@ -56,7 +57,6 @@ import net.minecraft.world.level.levelgen.feature.Feature; import net.minecraft.world.level.levelgen.feature.WeightedPlacedFeature; import net.minecraft.world.level.levelgen.feature.configurations.BlockPileConfiguration; -import net.minecraft.world.level.levelgen.feature.configurations.ColumnFeatureConfiguration; import net.minecraft.world.level.levelgen.feature.configurations.MultifaceGrowthConfiguration; import net.minecraft.world.level.levelgen.feature.configurations.OreConfiguration; import net.minecraft.world.level.levelgen.feature.configurations.RandomBooleanFeatureConfiguration; @@ -80,8 +80,8 @@ public final class WWCaveConfigured { public static final FrozenLibConfiguredFeature> PURPLE_MESOGLEA_COLUMN = register("purple_mesoglea_column"); public static final FrozenLibConfiguredFeature> DOWNWARDS_BLUE_MESOGLEA_COLUMN = register("downwards_blue_mesoglea_column"); public static final FrozenLibConfiguredFeature> DOWNWARDS_PURPLE_MESOGLEA_COLUMN = register("downwards_purple_mesoglea_column"); - public static final FrozenLibConfiguredFeature> BLUE_MESOGLEA_PATH = register("blue_mesoglea_path"); - public static final FrozenLibConfiguredFeature> PURPLE_MESOGLEA_PATH = register("purple_mesoglea_path"); + public static final FrozenLibConfiguredFeature> BLUE_MESOGLEA_PATH = register("blue_mesoglea_path"); + public static final FrozenLibConfiguredFeature> PURPLE_MESOGLEA_PATH = register("purple_mesoglea_path"); public static final FrozenLibConfiguredFeature> MESOGLEA_CLUSTER_PURPLE = WWFeatureUtils.register("mesoglea_cluster_purple"); public static final FrozenLibConfiguredFeature> MESOGLEA_CLUSTER_BLUE = WWFeatureUtils.register("mesoglea_cluster_blue"); public static final FrozenLibConfiguredFeature> BLUE_MESOGLEA_WITH_DRIPLEAVES = WWFeatureUtils.register("blue_mesoglea_with_dripleaves"); @@ -230,10 +230,10 @@ public static void registerCaveConfigured(@NotNull BootstrapContext( BuiltInRegistries.BLOCK.holderOwner(), WWBlockTags.MESOGLEA_PATH_REPLACEABLE @@ -250,10 +250,10 @@ public static void registerCaveConfigured(@NotNull BootstrapContext( BuiltInRegistries.BLOCK.holderOwner(), WWBlockTags.MESOGLEA_PATH_REPLACEABLE