Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Passing Chips as a Parameter #161

Open
falo2k opened this issue Oct 3, 2024 · 5 comments
Open

Support Passing Chips as a Parameter #161

falo2k opened this issue Oct 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@falo2k
Copy link

falo2k commented Oct 3, 2024

Describe the feature or hardware support you'd like

Would it be possible to add a CHIPS parameter as with TEST_RESONANCES to select the chip we want to use where more are defined? When using something like Danger Klipper's optional mcu for nozzle probes, you can't have the optional mcu defined in the accel_chip attribute of resonance_tester (as it sometimes doesn't exist yet), but you can pass the defined chip to TEST_RESONANCES using CHIP=. It would also be handy even for fixed mount sensors, when you want to take readings from different positions and compare.

Additional context or information

No response

@falo2k falo2k added the enhancement New feature or request label Oct 3, 2024
@yzheka
Copy link

yzheka commented Dec 30, 2024

You should not pass CHIPS parameter, it is not needed. Instead of this you have to use axis where each chip is fixed to. Anyway this is the question to the Klipper firmware but not the shaketune

@falo2k
Copy link
Author

falo2k commented Dec 30, 2024

I suggest you read again. One use case is where you may have multiple chips reflecting the same axes (e.g. nozzle mounted, board mounted, etc.) and want to compare the results against each other while looking for possible factors that are causing certain results.

It is absolutely not a question to Klipper firmware - it is a request for the same flexibility offered in calling native Klipper macros to be mirrored in shaketune.

@yzheka
Copy link

yzheka commented Dec 30, 2024

I suggest you read again. One use case is where you may have multiple chips reflecting the same axes (e.g. nozzle mounted, board mounted, etc.) and want to compare the results against each other while looking for possible factors that are causing certain results.

It is absolutely not a question to Klipper firmware - it is a request for the same flexibility offered in calling native Klipper macros to be mirrored in shaketune.

then there should be a separate version for danger klipper. coz those parameters will not be supported in regular klipper

@falo2k
Copy link
Author

falo2k commented Dec 30, 2024

@yzheka
Copy link

yzheka commented Dec 30, 2024

Except ... they are?

https://www.klipper3d.org/Measuring_Resonances.html#measuring-the-resonances

ahh, wow. I did'n know that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants