Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param to AXES_SHAPER_CALIBRATION for auto-saving the recommended input shapers to config #111

Open
PhilippMolitor opened this issue Jun 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@PhilippMolitor
Copy link

PhilippMolitor commented Jun 6, 2024

Describe the feature or hardware support you'd like

I really love using this tool for my IS tuning!
One thing I would really like to do it to run AXES_SHAPER_CALIBRATION and directly save its recommendation to the config.

I imagine something like AXES_SHAPER_CALIBRATION SAVE=1
To have the following added to my autosave config:

[input_shaper]
shaper_freq_x: 61.4
shaper_freq_y: 43.4
shaper_type_x: mzv
shaper_type_y: mzv
damping_ratio_x: 0.1
damping_ratio_y: 0.1

The main advantage would also be the addition of damping_ratio for X and Y, which SHAPER_CALIBRATE currently does not do. ShakeTune recommends values for those, so that should also be possible.

Alternatively, there could also be an option to select the best input shaper depending on the user's requirements:
AXES_SHAPER_CALIBRATION SAVE=performance or AXES_SHAPER_CALIBRATION SAVE=quality
to select one of the different recommendations that KS S&T made.

Additional context or information

No response

@PhilippMolitor PhilippMolitor added the enhancement New feature or request label Jun 6, 2024
@Frix-x
Copy link
Owner

Frix-x commented Jun 27, 2024

That's actually a great idea! I'll keep it in my head for a next version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants