Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sampling between different kHz / Choosing the sample rate at recording #33

Open
6 of 7 tasks
RustoMCSpit opened this issue Feb 26, 2024 · 4 comments · May be fixed by #92
Open
6 of 7 tasks

Re-sampling between different kHz / Choosing the sample rate at recording #33

RustoMCSpit opened this issue Feb 26, 2024 · 4 comments · May be fixed by #92
Assignees
Labels
feature request Issue is about a new feature in the app

Comments

@RustoMCSpit
Copy link

RustoMCSpit commented Feb 26, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request. (Potentially two, needs triage. These are so linked that it's hard to tell if it's one)
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

There are different kHz amounts: 44.1 kHz, 48kHz etc.
Allowing a user to choose the sample rate and resample audio is thus needed.

Why do you want this feature?

Some programs take different amounts, different file sizes, etc.

Additional information

#32 related to this

@RustoMCSpit RustoMCSpit added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 26, 2024
@RustoMCSpit RustoMCSpit changed the title Re-sampling between different kHz Re-sampling between different kHz / Choosing the sample rate at recording Feb 26, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 26, 2024
@SilverPuppy
Copy link

SilverPuppy commented Oct 1, 2024

Resampling is not needed. The ability to choose the sample rate for the new recording is important. People have preferences, and changing it can also allow better results in certain scenarios, such as low bitrate recording.

The fact that it is not possible stops me from resolving an issue with Opus recording manually. The default sample rate is obviously 44,100 which is unsupported by Opus, so it takes the data, but marks it as 48,000 which results in slightly high pitched playback. If I could manually select 24,000 or 48,000 which are supported, there would be no issue.

@HT-7
Copy link

HT-7 commented Oct 18, 2024

Agreed. Both sampling rate and bitrate please. And while you're at it, please add an option for OGG vorbis.

ASR by NLL apps had manual sampling rate and bitrate a decade ago. I would use ASR but because "benevolent" Google has killed all 32-bit apps in Android 14, I can forget about that.

@SilverPuppy
Copy link

SilverPuppy commented Jan 25, 2025

The recent change of the default sampling rate from 44,100 to 48,000 resolves the Opus incompatibility, but having the ability to specify one would be valuable at times. I still believe this needs to be implemented. One way would be a dropdown with common rates, perhaps

8000 (VoIP)
11025
16000
22050
24000
32000
44100 (CD)
48000 (DVD)

Alternatively, display a line in settings "Sample Rate: [box displaying number of Hz] and a toggle switch below it "Customize sample rate (may cause errors)" which makes the box editable. Switch off, the box should be grayed and display the default of 48000Hz.

Honestly, anyone who wishes to change the sample rate from the default probably knows what rates to use and doesn't need a drop down menu.

Edit: I looked at how bitrate is handled, with common preprogrammed options, and added more options to my list, since it looks likely that this would be the easiest to implement as the structure seems to be in place for that type of menu already. I would add that I would prefer to be able to use any arbitrary value for bitrate as well, but the present menu system is far better than not having a choice, and I consider it good enough. Maybe adding a "custom" option to both in the future would be possible.

@naveensingh
Copy link
Member

I still believe this needs to be implemented.

It will be added along with other options commonly found in third party voice recorder apps.

@Aga-C Aga-C self-assigned this Jan 26, 2025
Aga-C added a commit to Aga-C/Voice-Recorder that referenced this issue Jan 26, 2025
@Aga-C Aga-C linked a pull request Jan 26, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants