-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
long press a link to copy it #107
Comments
Hey ! I'm a student at University Paris 8 and for the purpose of one of my course I have to solve an issue of my choice on Github. I would like to solve this one. Is anyone already on it or can I work on it ? |
You can work on it. |
Nice ! Thank you for your quick response, I'll begin ASAP. |
Hey again, i have a quick question, when i long click on a link it highlight that url, i'm trying to locate where is this made in the code, could you help me pls ? |
You can find some relevant code in ThreadActivity and ThreadAdapter. It's always a good idea to familiarize yourself with a project before you start working on it or better, pick projects you are already familiar with. |
Checklist
Feature description
Currently, the way to copy a link from a message is to long press it>three dots>select text>select the link>copy.
I suggest instead that when one long-presses specifically the link part of a message, that that link be auto-copied to clipboard.
This is common behaviour in other messengers, see for example on Signal:
signal.comparison.mp4
Why do you want this feature?
I get quite a few messages with links, mostly from organisations that still use SMS. Having this feature will greatly speeds up my workflow.
Additional information
One argument that I can see is that implementing the same behaviour as Signal will make it harder to select the whole message, as some of that area will now be dedicated to the link alone. While I disagree this is a big issue (the empty area next to the message is still selectable), a reasonable compromise will be to keep both behaviours - long-pressing a link both copies it and selects the message as a whole.
The text was updated successfully, but these errors were encountered: