Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long press a link to copy it #107

Open
7 tasks done
nehemiagurl opened this issue Feb 18, 2024 · 5 comments · May be fixed by #320
Open
7 tasks done

long press a link to copy it #107

nehemiagurl opened this issue Feb 18, 2024 · 5 comments · May be fixed by #320
Labels
feature request Issue is about a new feature in the app

Comments

@nehemiagurl
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Currently, the way to copy a link from a message is to long press it>three dots>select text>select the link>copy.
I suggest instead that when one long-presses specifically the link part of a message, that that link be auto-copied to clipboard.
This is common behaviour in other messengers, see for example on Signal:

signal.comparison.mp4

Why do you want this feature?

I get quite a few messages with links, mostly from organisations that still use SMS. Having this feature will greatly speeds up my workflow.

Additional information

One argument that I can see is that implementing the same behaviour as Signal will make it harder to select the whole message, as some of that area will now be dedicated to the link alone. While I disagree this is a big issue (the empty area next to the message is still selectable), a reasonable compromise will be to keep both behaviours - long-pressing a link both copies it and selects the message as a whole.

@nehemiagurl nehemiagurl added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Feb 18, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 18, 2024
@pufferss
Copy link

Hey ! I'm a student at University Paris 8 and for the purpose of one of my course I have to solve an issue of my choice on Github. I would like to solve this one. Is anyone already on it or can I work on it ?

@naveensingh
Copy link
Member

You can work on it.

@pufferss
Copy link

Nice ! Thank you for your quick response, I'll begin ASAP.

@pufferss
Copy link

Hey again, i have a quick question, when i long click on a link it highlight that url, i'm trying to locate where is this made in the code, could you help me pls ?

@naveensingh
Copy link
Member

You can find some relevant code in ThreadActivity and ThreadAdapter.

It's always a good idea to familiarize yourself with a project before you start working on it or better, pick projects you are already familiar with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
4 participants