Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for duplication between ct.yaml and the release GH action #105

Open
plumdog opened this issue Oct 26, 2022 · 2 comments
Open

Comments

@plumdog
Copy link
Contributor

plumdog commented Oct 26, 2022

Both have to know about the chart repos for the chart dependencies, so need to be kept in sync. There might be a nicer way, but helm/chart-releaser#135 suggests maybe not.

Maybe something faintly bonkers like:

yq -r '.chart-repos[]' ct.yaml | sed 's/=/ /' | xargs -L helm repo add

in the release action is OK.

@matthewelwell
Copy link
Contributor

@plumdog I see that we merged a PR against this one above - can we resolve this issue?

@plumdog
Copy link
Contributor Author

plumdog commented Aug 2, 2023

@matthewelwell the merged PR is the sad "just define the repos in two places to fix the brokenness" fix. This issue is about removing that duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants