-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not scroll with page #8
Comments
This raises another issue though. If you have a long page that goes longer than the fold of a site, and you click a link at the bottom, the box may show up above the fold and out of your current viewport. I believe a solution may be to initially fix the position of the box to x pixels from the top. Then, get the position of the window and change its position to absolute so you can scroll. I may try to code this and do a pull request. |
True.. You can use something like.. |
eipark raises a good point. While changing position from fixed to absolute fixes the scrolling problem, it raises the problem of modals popping up well above the fold. Anyone have any possible solutions here? |
Well, here's the workaround I eventually settled on: Leave position: fixed, and add these lines to the js: "max-height": 80 + "%", This will ensure that the modal is always in current viewport, is never larger than current viewport, and will scroll if content exceeds current height. |
When the viewport is smaller than the modal popup, you cannot scroll it to see the additional content or close box.
FIX: change style: position from fixed to absolute
The text was updated successfully, but these errors were encountered: