Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User_id check in Patch item is useless #126

Open
nichyjt opened this issue Jul 5, 2022 · 1 comment
Open

User_id check in Patch item is useless #126

nichyjt opened this issue Jul 5, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@nichyjt
Copy link
Member

nichyjt commented Jul 5, 2022

Two useless checks:

  1. Backend Microservice
    The backend requires that User_id be passed as a URL parameter. This is useless a the request body itself should contain User_id, implying that the item belongs to the LOST collection of items
  2. Item Microservice
    User_id is checked via URL param - but this is useless. The User_id existence should be checked via the request body iteself
@nichyjt nichyjt added the bug Something isn't working label Jul 5, 2022
@nichyjt nichyjt added this to the Sprint 4 (Milestone 3) milestone Jul 5, 2022
@nichyjt nichyjt self-assigned this Jul 5, 2022
@nichyjt nichyjt added enhancement New feature or request and removed bug Something isn't working labels Jul 5, 2022
@nichyjt nichyjt removed this from the Sprint 4 (Milestone 3) milestone Jul 5, 2022
@nichyjt
Copy link
Member Author

nichyjt commented Jul 5, 2022

Re-labelled this to enhancement for now because this is lower priority and not breaking. This is a good-to-have optimization. Further, URL depreciation can be done without breaking the frontend logic.

@nichyjt nichyjt added the wontfix This will not be worked on label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant