Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query parameter validation #16

Open
mrodriguez3313 opened this issue Feb 16, 2022 · 0 comments
Open

Add query parameter validation #16

mrodriguez3313 opened this issue Feb 16, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request P0 Critical: Fierro team is actively pursuing solution

Comments

@mrodriguez3313
Copy link
Collaborator

mrodriguez3313 commented Feb 16, 2022

Add checks to make sure we get a valid parameter values. That way we don't save or even import the key on a publish function. This will save time and not require backtracking work to delete potentially saved keys.

This is in reference to this function https://github.com/mrodriguez3313/IPNSGoServer/blob/1acc150aa82717528482b07d56da516faffcf9d1/server.go#L61

EDIT** Changed slightly to this now:

func HasParam(r *http.Request, parameter string) (string, bool) {

@mrodriguez3313 mrodriguez3313 added enhancement New feature or request help wanted Extra attention is needed labels Feb 16, 2022
@mrodriguez3313 mrodriguez3313 changed the title Add CID validation Add query parameter validation Feb 16, 2022
@mrodriguez3313 mrodriguez3313 added P0 Critical: Fierro team is actively pursuing solution bug Something isn't working and removed help wanted Extra attention is needed labels Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request P0 Critical: Fierro team is actively pursuing solution
Projects
None yet
Development

No branches or pull requests

1 participant