Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JiJ'ed mods inside modImplementation dependencies are not present at runtime #1242

Open
Earthcomputer opened this issue Jan 2, 2025 · 3 comments

Comments

@Earthcomputer
Copy link
Contributor

Actual behaviour:
JiJ'ed mods included inside mods included via modImplementation are not present when running the game, leading to crashes.

Expected behaviour:
Such JiJ'ed mods are picked up by fabric loader and loaded at runtime. They should not necessarily be available to compile against.

If the mods are included in the pom files, then strip those mods out of JiJ like we currently do, otherwise keep them in and recursively remap them. At least, there should be an option for this behaviour, as it's a frequent pain point for those who make add-on mods to other mods.

@AnAwesomGuy
Copy link

i'd love for this to get implemented, is architectury#236 the same?
for example, sodium (neoforge, bad example ik) JiJs some fabric-api modules and also a custom services jar, so it will crash in-dev.

@deirn
Copy link
Member

deirn commented Jan 4, 2025

Already mentioned it on Discord, but might as well post it here.

I made this Gradle plugin, Explosion, since I especially need to access the JiJ at compile time for making some compat mod.
It does this by hacking Fabric Loader, essentially running it as if it was in prod to get the Jar.

Edit: also, it has a NeoForge extractor, though I'm not yet using it on my projects.

@thebluetropics
Copy link

I am not sure what is this thread about, but it seems like I am going to face it in the future, so I commented this here, good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants