Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error handling #1

Open
aaronleopold opened this issue Mar 16, 2021 · 0 comments
Open

update error handling #1

aaronleopold opened this issue Mar 16, 2021 · 0 comments

Comments

@aaronleopold
Copy link
Member

I think using anyhow and/or thiserror might be beneficial, something like this:

#[derive(Debug, Error)]
pub enum Error {
    #[error("Some defined error: {0}")]
    DefinedErrorName(Box<dyn std::error::Error>),
    #[error("There was an unexpected error: {0}")]
    Other(Box<dyn std::error::Error>),
}

I should also remove some of the unsafe/unchecked unwraps in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant