Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to support video? #33

Open
Eric0625 opened this issue Dec 19, 2017 · 6 comments
Open

Any plan to support video? #33

Eric0625 opened this issue Dec 19, 2017 · 6 comments

Comments

@Eric0625
Copy link

It would be great to select videos

@SebastianBO
Copy link

Any update on this?

@mats-claassen
Copy link
Member

mats-claassen commented Oct 3, 2018

This is not in the roadmap for now but we could add an example.

You could try setting presentationMode or using row.onPresent to configure the picker controller

@mats-claassen
Copy link
Member

Thinking it through a bit more, you cannot use ImageRow as the value of the row is an UIImage and you will probably want an URL or something to represent the video.

What can be done is: create a new row using most of the logic from ImageRow, set the type of the value of the row to URL, change the ImagePickerController to take set the url of the picked video as value of the row. Finally get a thumbnail of the video to show in the row (could be done with AVAssetImageGenerator).

However, this would be a row to pick a video and not a video or image. For that we would have to create a row whose value is an enum or other structure to allow both.

Does this sound reasonable?

@Eric0625
Copy link
Author

Eric0625 commented Oct 8, 2018

Maybe we can create a row whose return value is PHAsset? That way the image and video would both be supported.

@mats-claassen
Copy link
Member

That would be possible, yes

@SebastianBO SebastianBO mentioned this issue Oct 17, 2018
@mats-claassen
Copy link
Member

For selecting only videos use VideoRow.

Choosing images or videos requires a bigger restructure of ImageRow as mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants