Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault handling around ResourceFactory methods #44

Open
eperott opened this issue Nov 6, 2018 · 0 comments
Open

Fault handling around ResourceFactory methods #44

eperott opened this issue Nov 6, 2018 · 0 comments
Labels
code Opportunity for code or test improvement

Comments

@eperott
Copy link
Collaborator

eperott commented Nov 6, 2018

The ResourceFactory utility class throws IllegalArgumentException if an invalid resource String is passed in to any of its toResource() methods. This potential fault is not properly handled in WhitelistDataAccess and AuditWhitelistCache.

Error scenarios should result in proper Cassandra exception and reject client request. Behavior should be verified with integration tests.
@eperott eperott mentioned this issue Nov 6, 2018
Merged
@eperott eperott added the code Opportunity for code or test improvement label Nov 6, 2018
@RhoderickGalero RhoderickGalero moved this to Todo issue in C2T Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Opportunity for code or test improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eperott