Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer][clang-tidy] Consume reports and FixIts from --export-fixes YAML output instead of stdout/stderr #4063

Open
whisperity opened this issue Oct 27, 2023 · 1 comment
Assignees
Labels
analyzer 📈 Related to the analyze commands (analysis driver) clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. report-converter 🔄

Comments

@whisperity
Copy link
Contributor

Extracted from #4052

We should consider dropping the conversion from "random meaningless stdout text"-to-plist in favour of "well-formatted message and fix YAML"-to-plist. (Or SARIF?)

For a very long time now, Clang-Tidy was capable of dumping the structure of the created diagnostics (all the notes, warnings, and fixits, see https://github.com/llvm/llvm-project/blob/llvmorg-17.0.0/clang-tools-extra/test/clang-tidy/infrastructure/export-diagnostics.cpp!) in YAML.

@whisperity whisperity added analyzer 📈 Related to the analyze commands (analysis driver) clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. report-converter 🔄 labels Oct 27, 2023
@whisperity whisperity added this to the release 6.24.0 milestone Oct 27, 2023
@whisperity whisperity changed the title [analyzer][clang-tidy] [analyzer][clang-tidy] Consume reports and FixIts from --export-fixes YAML output instead of stdout/stderr Oct 27, 2023
@whisperity
Copy link
Contributor Author

Something changed likely after LLVM 18.0 was snapshotted and work on 19.0 begun, because now I'm seeing the following bogus parses from CodeChecker. | and ~~~~~~~~~ alone on lines are definitely not the right fixits.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. report-converter 🔄
Projects
None yet
Development

No branches or pull requests

3 participants