Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera configuration file names do not follow our naming convention #1

Open
noralinn opened this issue Nov 20, 2022 · 2 comments
Open

Comments

@noralinn
Copy link

The camera yml files are name 02_01_03, i.e. mount_node_telescope. But it should be node_mount_telescope.

I didn't check if it's the same for other configuration files.

@EastEriq
Copy link
Collaborator

Actually, 01 there was originally supposed to mean "mount # 1 of unit 02". I agree that we are no more considering units with more than a single mount. However, I'm somehow wary of changing it at once, as all the unit component .Ids (and hence their respective configuration files) descend from that of the unit, when it is created.
Long story short: https://github.com/PolishookDavid/LAST_OCS/blob/mastrolindo/%2Bobs/%40unitCS/unitCS.m should be changed (in the creator function, ~ https://github.com/PolishookDavid/LAST_OCS/blob/9ac42379b63025919caf30a83bf1c996bfa1ced6/%2Bobs/%40unitCS/unitCS.m#L54), all configuration files should be renamed, everything included images will change names, and I might be forgetting some other side eeffect.

@EastEriq
Copy link
Collaborator

Namely, Unit.Mount.Id is 'xx_01', and both Unit.Camera{i}.Id and Unit.Focuser{i}.Id are 'xx_01_0i' as of now.
You may want me to change them, expect that for two days we'll be in Oy gewalt mode.

Self note, see also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants