Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti-Exploit Breaks Weapons #847

Closed
L8X opened this issue Jul 1, 2022 · 9 comments
Closed

Anti-Exploit Breaks Weapons #847

L8X opened this issue Jul 1, 2022 · 9 comments
Labels
🛡️ anti-exploit The Adonis anti-exploit system/anti-exploit features 🐛 bug Bugs or broken features

Comments

@L8X
Copy link
Contributor

L8X commented Jul 1, 2022

I have a client who I am doing security for, and we've noticed with all anti-exploit components enabled (minus AntiLeak), it breaks all weapon tools.

It appears that something is either preventing the swords from dealing damage, or firing the touchinterests for the damage trigger.

Repro steps:

Copy our config (all antiexploit components minus AntiLeak must be on)

Insert a linkedsword (such as the one made by Roblox) and try damaging a fellow player, it should then fail to work.

RFC:
Anyone got any ideas as to what's causing this?

@L8X L8X added the 🐛 bug Bugs or broken features label Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

👋 Welcome! It looks like this is your first issue submission here. Please make sure you've included all necessary details in your post so we can reach a resolution as painlessly as possible! Also note that not recieving a response does not mean that your issue has been ignored!

@L8X
Copy link
Contributor Author

L8X commented Jul 1, 2022

I've looked into the components in question, and there's nothing that filters touchinterests out or prevents damage, from what I can tell, so I'm confused on this one.

@Expertcoderz Expertcoderz removed their assignment Jul 1, 2022
@Expertcoderz Expertcoderz added the 🛡️ anti-exploit The Adonis anti-exploit system/anti-exploit features label Jul 1, 2022
@chexburger
Copy link
Contributor

Only exploits can block a signal from being fired, and on the client. Adonis cannot block any signals. Something else in the game must be preventing it.
Additionally, do not rely on Adonis for anti-exploit. Many of those pre-date when filtering was forced on games. Instead, anti-exploits should be largely done with sanity checks by the game itself. No game is the same.

@L8X
Copy link
Contributor Author

L8X commented Jul 1, 2022

Only exploits can block a signal from being fired, and on the client. Adonis cannot block any signals. Something else in the game must be preventing it. Additionally, do not rely on Adonis for anti-exploit. Many of those pre-date when filtering was forced on games. Instead, anti-exploits should be largely done with sanity checks by the game itself. No game is the same.

It's not an exploit causing it, the issue happens for everyone.

@chexburger
Copy link
Contributor

It's not an exploit causing it, the issue happens for everyone.

Wasn't saying it was an exploit. I was saying only exploits can block it. Adonis does not block touched events and cannot block touched events.
I recommend you check collision groups and whether the sword can trigger touched on them along with whether the sword and target parts have CanTouch enabled.

@WaviestBalloon
Copy link
Contributor

WaviestBalloon commented Aug 14, 2022

I've tried replicating this issue, it will still kill the player for me. Are you running a old version of Adonis? You've described your configuration having AntiLeak, which was removed in this commit #810. (5296d86)

@WaviestBalloon
Copy link
Contributor

I think this might be a dead Issue

@ccuser44
Copy link
Contributor

Can you reproduce this issue again?
If so please give all debug information you can

@Dimenpsyonal
Copy link
Member

This feature has been removed so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛡️ anti-exploit The Adonis anti-exploit system/anti-exploit features 🐛 bug Bugs or broken features
Projects
None yet
Development

No branches or pull requests

7 participants
@chexburger @WaviestBalloon @L8X @Dimenpsyonal @ccuser44 @Expertcoderz and others