-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default prefix to ; #1829
base: master
Are you sure you want to change the base?
Conversation
This is not true |
Changing this to a slash would make sense but changing to |
Changing to ; makes sense!!! I have to press shift to get to : whereas I only have to tap a key to get ; |
I only see this becoming a problem if somebody is using multiple admin systems in one game (which in some cases make sense but other than that, no it doesn't) |
also @Dimenpsyonal wasnt |
idk maybe |
Also the most "harm" I see this doing is breaking existing aliases people have created (in which can easily be fixed on THEIR end) and just overall confusion |
|
But most people in the world (excluding US+UK) have to press shift for both If you had to change this to something else then you should use |
Would confuse long time Adonis users including myself. Maybe add a way for the user to change their own prefix via the userpanel |
This exists already |
also, this only changes the default prefix! people can still set the prefix to use |
Oh yeahhh |
Slash should be left alone as its for TextChatService commands (and for inbuilt roblox commands such as /emote and /console) |
I see no reason as to why not change it to
Like mentioned here this wouldn't affect older games. |
Don't use horrible logic, this is how we get stuff like the adonis anticheat. |
Yall complaining about the default prefix when you can just change it in settings...... |
Most users of the internet are not in the anglosphere |
Yeah but this isn't the internet at large... It's roblox |
If you really think this is a problem, why not just have a pop up for first time players that lets them pick which prefix to use
This gets rid of confusion while still allowing players to easily modify the settings to what they prefer. This also doesn't force long term Adonis users to go into the settings after they are wondering why the : prefix isn't working for them Another solution would be to give them a notification when using the default prefix that tells them the game uses a custom prefix |
Ah right, I totally forgot about that |
have you ever tried running commands like |
This is also true – using ; gets rid of the problem wherein Roblox thinks you're adding emotes |
THIS >>>> |
That's an actual actually valid argument for changing the prefix. Unlike the "have to press shift key" if you can't press 2 keys at the same time then so.ethings realmy wrong. Anyways there is still a way you can type commands in the new chat without it guessing an emote via appending a slash before it. |
In the future though (maybe in Adonis 2.9) we should transition to slash commands in a regular orefix comma ds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
The chat box is not a command line. |
Then how come you can run commands in it huh buddy |
And the results are in... 59% yes versus 41% no |
This is not true, it’s 57% to 43%, which is bad ad there’s still MANY
people that disagree clearly. the fact its not even above 60%
|
Exactly. The result isn't a simple supermajority therefor debate has to be had if merging could even happen. |
yeesh sore losers |
As a certified adonis code I would keep the prefix as is as it would cause great change to tthose as it was always the : i assume and the player can just change it to ; its not a good idea to force it. Or another alternative would be make all commands have same prefix so you wouldnt need to press ; twice |
i am also a certified adonis code i would like to make note of the fact that the poll won in the favour of the semicolon, and it would only affect new loaders |
@ccuser44 @GalacticInspired why exactly are you so against this can you specify all your points in one message |
How about we just add both prefixes instead of deciding which prefix is superior (forgot who suggested it but yeah) and then have a setting that lets you add your own prefixes |
It was me I suggested allowing commands to take a table of prefixes like so local Command = {
Name = "test",
Prefix = {":", ";"},
} So you could do :test or ;test This fixes the issue of breaking old aliases and muscle memory while also gaining the benefits of using ; as the prefix. I think this is the best solution, it just requires a bit of work to make commands accept table prefixes. They also should accept just a string to not break old plugins and the such. |
that's a pretty radical overhaul of the code base for a literally 2 character change |
OP, consider keeping yourself safe |
unless you people can come up with an actual, reasoned argument as to why |
radiosilence |
Revival of #237. Feedback requested
Doing so makes it easier to use Adonis' commands, as on most major keyboards and computers, the : key requires the use of the shift button, whereas the ; key does not, thus making it easier for moderators and admins to access Adonis commands.