Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default prefix to ; #1829

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Dimenpsyonal
Copy link
Member

Revival of #237. Feedback requested

Doing so makes it easier to use Adonis' commands, as on most major keyboards and computers, the : key requires the use of the shift button, whereas the ; key does not, thus making it easier for moderators and admins to access Adonis commands.

@ccuser44
Copy link
Contributor

whereas the ; key does not,

This is not true

@ccuser44
Copy link
Contributor

Changing this to a slash would make sense but changing to ; is just unnecessary and potentially harmful. Don't fix it if it's not broken. Also would concflict with other admins

@Dimenpsyonal
Copy link
Member Author

Changing to ; makes sense!!! I have to press shift to get to : whereas I only have to tap a key to get ;

@WalkerOfBacon
Copy link
Contributor

Also would concflict with other admins

I only see this becoming a problem if somebody is using multiple admin systems in one game (which in some cases make sense but other than that, no it doesn't)

@WalkerOfBacon
Copy link
Contributor

also @Dimenpsyonal wasnt settings.DefaultTheme removed to prevent ppl from modifying it bc they dont read about what it actually does?

@Dimenpsyonal
Copy link
Member Author

idk maybe

@WalkerOfBacon
Copy link
Contributor

Also the most "harm" I see this doing is breaking existing aliases people have created (in which can easily be fixed on THEIR end) and just overall confusion

@WalkerOfBacon
Copy link
Contributor

idk maybe

#1459 (comment)

@ccuser44
Copy link
Contributor

I have to press shift

But most people in the world (excluding US+UK) have to press shift for both : and ; therefore the usefullness of the change is severy limited. Changing this would only lead to confusion. If you really need this for yourself change the settings prefix or alternatively add an alias via !client that is ;<command> = :<command>

If you had to change this to something else then you should use / but do NOT change this to ;

@convxors
Copy link
Contributor

Would confuse long time Adonis users including myself. Maybe add a way for the user to change their own prefix via the userpanel

@WalkerOfBacon
Copy link
Contributor

Would confuse long time Adonis users including myself. Maybe add a way for the user to change their own prefix via the userpanel

This exists already

@Dimenpsyonal
Copy link
Member Author

Also the most "harm" I see this doing is breaking existing aliases people have created (in which can easily be fixed on THEIR end) and just overall confusion

also, this only changes the default prefix! people can still set the prefix to use :, this PR only changes the default prefix used on new loaders

@WalkerOfBacon
Copy link
Contributor

also, this only changes the default prefix! people can still set the prefix to use :, this PR only changes the default prefix used on new loaders

Oh yeahhh

@PurpleCreativity
Copy link
Contributor

Changing this to a slash would make sense but changing to ; is just unnecessary and potentially harmful. Don't fix it if it's not broken. Also would concflict with other admins

I have to press shift

But most people in the world (excluding US+UK) have to press shift for both : and ; therefore the usefullness of the change is severy limited. Changing this would only lead to confusion. If you really need this for yourself change the settings prefix or alternatively add an alias via !client that is ;<command> = :<command>

If you had to change this to something else then you should use / but do NOT change this to ;

Slash should be left alone as its for TextChatService commands (and for inbuilt roblox commands such as /emote and /console)

@PurpleCreativity
Copy link
Contributor

I see no reason as to why not change it to ; as It's easier to press for MOST users on the internet.

Also the most "harm" I see this doing is breaking existing aliases people have created (in which can easily be fixed on THEIR end) and just overall confusion

also, this only changes the default prefix! people can still set the prefix to use :, this PR only changes the default prefix used on new loaders

Like mentioned here this wouldn't affect older games.

@PurpleCreativity
Copy link
Contributor

Don't fix it if it's not broken.

Don't use horrible logic, this is how we get stuff like the adonis anticheat.

@8ch32bit
Copy link

Yall complaining about the default prefix when you can just change it in settings......

@ccuser44
Copy link
Contributor

I see no reason as to why not change it to ; as It's easier to press for MOST users on the internet.

Most users of the internet are not in the anglosphere

@Dimenpsyonal
Copy link
Member Author

Dimenpsyonal commented Jan 14, 2025

Yeah but this isn't the internet at large... It's roblox

@Z3phrz
Copy link
Contributor

Z3phrz commented Jan 15, 2025

If you really think this is a problem, why not just have a pop up for first time players that lets them pick which prefix to use

  • Changing the default prefix for all new games will just confuse players that use Adonis a lot
  • Have the default settings pop up for the game owner when they join the first time for people that struggle to edit the script
  • Have a notification popup for first time players that they can click to bring up client settings
  • When returning players join the game, just show them what the current prefix is in the join notification

This gets rid of confusion while still allowing players to easily modify the settings to what they prefer. This also doesn't force long term Adonis users to go into the settings after they are wondering why the : prefix isn't working for them

Another solution would be to give them a notification when using the default prefix that tells them the game uses a custom prefix

@convxors
Copy link
Contributor

Also the most "harm" I see this doing is breaking existing aliases people have created (in which can easily be fixed on THEIR end) and just overall confusion

also, this only changes the default prefix! people can still set the prefix to use :, this PR only changes the default prefix used on new loaders

Ah right, I totally forgot about that

@PurpleCreativity
Copy link
Contributor

I see no reason as to why not change it to ; as It's easier to press for MOST users on the internet.

Most users of the internet are not in the anglosphere

have you ever tried running commands like :re in the new roblox chat? because it's either impossible or really annoying to do as it autocompletes to some dumb emote

@Dimenpsyonal
Copy link
Member Author

This is also true – using ; gets rid of the problem wherein Roblox thinks you're adding emotes

@WalkerOfBacon
Copy link
Contributor

have you ever tried running commands like :re in the new roblox chat? because it's either impossible or really annoying to do as it autocompletes to some dumb emote

THIS >>>>

@ccuser44
Copy link
Contributor

I see no reason as to why not change it to ; as It's easier to press for MOST users on the internet.

Most users of the internet are not in the anglosphere

have you ever tried running commands like :re in the new roblox chat? because it's either impossible or really annoying to do as it autocompletes to some dumb emote

That's an actual actually valid argument for changing the prefix. Unlike the "have to press shift key" if you can't press 2 keys at the same time then so.ethings realmy wrong.

Anyways there is still a way you can type commands in the new chat without it guessing an emote via appending a slash before it.
Like /:fly me and as a bonus you get autocompletion for all Afonis commands

@ccuser44
Copy link
Contributor

In the future though (maybe in Adonis 2.9) we should transition to slash commands in a regular orefix comma ds

Copy link
Contributor

@GalacticInspired GalacticInspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@GalacticInspired
Copy link
Contributor

This is also true – using ; gets rid of the problem wherein Roblox thinks you're adding emotes

The chat box is not a command line.

@Dimenpsyonal
Copy link
Member Author

Then how come you can run commands in it huh buddy

@Dimenpsyonal Dimenpsyonal added ⚠️ major Relating to problems that majorly affect Adonis functionality or break core features 🖇️ loader The Adonis Loader and loader settings labels Jan 20, 2025
@Dimenpsyonal
Copy link
Member Author

And the results are in... 59% yes versus 41% no

@GalacticInspired
Copy link
Contributor

GalacticInspired commented Jan 24, 2025 via email

@ccuser44
Copy link
Contributor

This is not true, it’s 57% to 43%, which is bad ad there’s still MANY
people that disagree clearly. the fact its not even above 60%

Exactly. The result isn't a simple supermajority therefor debate has to be had if merging could even happen.

@Dimenpsyonal
Copy link
Member Author

yeesh sore losers

@LeoDeCow
Copy link

As a certified adonis code I would keep the prefix as is as it would cause great change to tthose as it was always the : i assume and the player can just change it to ; its not a good idea to force it. Or another alternative would be make all commands have same prefix so you wouldnt need to press ; twice

@PurpleCreativity
Copy link
Contributor

PurpleCreativity commented Jan 24, 2025

As a certified adonis code I would keep the prefix as is as it would cause great change to tthose as it was always the : i assume and the player can just change it to ; its not a good idea to force it. Or another alternative would be make all commands have same prefix so you wouldnt need to press ; twice

i am also a certified adonis code i would like to make note of the fact that the poll won in the favour of the semicolon, and it would only affect new loaders

@PurpleCreativity
Copy link
Contributor

@ccuser44 @GalacticInspired why exactly are you so against this can you specify all your points in one message

@WalkerOfBacon
Copy link
Contributor

How about we just add both prefixes instead of deciding which prefix is superior (forgot who suggested it but yeah) and then have a setting that lets you add your own prefixes

@SuperCater
Copy link
Contributor

How about we just add both prefixes instead of deciding which prefix is superior (forgot who suggested it but yeah) and then have a setting that lets you add your own prefixes

It was me

I suggested allowing commands to take a table of prefixes like so

local Command = {
Name = "test",
Prefix = {":", ";"},
}

So you could do :test or ;test

This fixes the issue of breaking old aliases and muscle memory while also gaining the benefits of using ; as the prefix. I think this is the best solution, it just requires a bit of work to make commands accept table prefixes. They also should accept just a string to not break old plugins and the such.

@Dimenpsyonal
Copy link
Member Author

that's a pretty radical overhaul of the code base for a literally 2 character change

@LolloDev5123
Copy link
Contributor

OP, consider keeping yourself safe

@Dimenpsyonal
Copy link
Member Author

Dimenpsyonal commented Jan 25, 2025

unless you people can come up with an actual, reasoned argument as to why : is empirically better than ; other than "but old users" then I may very well merge this

@PurpleCreativity
Copy link
Contributor

unless you people can come up with an actual, reasoned argument as to why : is empirically better than ; other than "but old users" then I may very well merge this

@ccuser44 @GalacticInspired why exactly are you so against this can you specify all your points in one message

radiosilence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖇️ loader The Adonis Loader and loader settings ⚠️ major Relating to problems that majorly affect Adonis functionality or break core features
Projects
None yet
Development

Successfully merging this pull request may close these issues.