Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of repmgrd's "promote_command" and "follow_command" parameters #483

Open
ibarwick opened this issue Jul 30, 2018 · 0 comments
Assignees
Labels
improvement Improvement to repmgr behaviour/usability
Milestone

Comments

@ibarwick
Copy link
Collaborator

ibarwick commented Jul 30, 2018

Historically, repmgrd (when operating on a streaming replication node) has required provision of the promote_command and follow_command parameters, which should contain either repmgr standby promote/repmgr standby follow, or scripts which at some point execute those commands.

This is becoming a source of confusion, particularly with promote_command as it implies this will be used in other contexts where the local PostgreSQL node will be promoted (e.g. during switchovers); see e.g. #473.

To mitigate this, rename the parameters to repmgrd_promote_command and repmgrd_follow_command respectively, keeping the original parameters for backwards compatibility.

Additionally, investigate whether it makes sense to have repmgrd perform the promote/follow actions directly, if no values supplied for these parameters; this will make basic configuration easier.

@ibarwick ibarwick self-assigned this Jul 30, 2018
@ibarwick ibarwick added the improvement Improvement to repmgr behaviour/usability label Jul 30, 2018
@ibarwick ibarwick modified the milestones: 4.2.0, 4.1.0 Jul 30, 2018
@ibarwick ibarwick changed the title Improve handling of repmgd Improve handling of repmgrd's "promote_command" and "follow_command" parameters Jul 30, 2018
@ibarwick ibarwick modified the milestones: 4.2.0, 4.3.0 Oct 3, 2018
@ibarwick ibarwick modified the milestones: 4.3.0, 4.4.0 Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to repmgr behaviour/usability
Projects
None yet
Development

No branches or pull requests

1 participant