From 409750972674188d907f024fa21720117283d0a0 Mon Sep 17 00:00:00 2001 From: Jon Holman <9025884+JonHolman@users.noreply.github.com> Date: Mon, 20 Mar 2023 18:17:58 -0400 Subject: [PATCH] fix(node version on runner): node16 to node18 (#49) * Added functionality to remove the current user as a watcher on the new ticket * added code to set priority based on severity * added axios to support removing watchers from tickets (jira-client does not include) * clean up * Added createdAt field to our findings and a filter to only create Jira issues if the finding has existed for longer than 24 hours * update output to prepare for sending to slack via GitHub action * Jira needs priority ID as a string in an object * update dependencies * Update macpro-security-hub-sync.ts * Update macpro-security-hub-sync.ts * updates based on PR feedback * upgrade from node 16 to 18 --- .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 2 +- .github/workflows/unit-tests.yml | 2 +- examples/.github/workflows/security-hub-jira-sync.yml | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0a55399..7d59ead 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci - run: npm run build - run: npx semantic-release diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3de52b6..5cea330 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,6 +20,6 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci - run: npm run test diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index b220943..5784129 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm install - run: npm run coverage - name: publish test coverage to code climate diff --git a/examples/.github/workflows/security-hub-jira-sync.yml b/examples/.github/workflows/security-hub-jira-sync.yml index 8f4d748..aa8224b 100644 --- a/examples/.github/workflows/security-hub-jira-sync.yml +++ b/examples/.github/workflows/security-hub-jira-sync.yml @@ -21,11 +21,11 @@ jobs: - name: Install Node uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 # AWS credentials must be provided to get findings from security hub; how you inject credentials can vary. - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v1-node16 + uses: aws-actions/configure-aws-credentials@v2 with: role-to-assume: ${{ secrets.AWS_OIDC_ROLE_TO_ASSUME }} aws-region: us-east-1