Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add recreate option for PR comments #643

Open
stas-sultanov opened this issue Mar 4, 2025 · 3 comments
Open

Feature Request: add recreate option for PR comments #643

stas-sultanov opened this issue Mar 4, 2025 · 3 comments

Comments

@stas-sultanov
Copy link

Very useful when Action associated with PR runs multiple times.
Just a flag that allows to remove old comment from PR and create it again.
The same feature as provided by marocchino/sticky-pull-request-comment

@EnricoMi
Copy link
Owner

EnricoMi commented Mar 4, 2025

Thanks! What is wrong with updating the existing comment?

@stas-sultanov
Copy link
Author

No, thank you for investing your lifetime in such a great tool.

Updating existing works perfectly fine.

But, I (and not only me) often open a pull request and continue working with branch to add \ fix code there. After each commit, the PR story line continues to update with new commits and builds.
And with the current behavior, your tool updates the comment which was prior the latest commits which has triggered new Actions \ Workflows.
With functionality to recreate the comment, all information published by the plugin will be last on the story line.

@EnricoMi
Copy link
Owner

EnricoMi commented Mar 4, 2025

So you want the test results to be at the bottom of the story line. That feature has been removed in v2.0.0: daf6bc5#diff-fbb8338261301c4ae0a4f01a8eb7b4a88d57b32a918e85231e2c0a2f78d7ff91

Deleting comments left a tombstone (a small note that a message has been deleted). Minimizing a message also leaves something behind. That made the PR story line crowed over time.

The advantage of having the test results stay at the top of the page is your latest test results are always the first thing you see when you land on the page. And you can check earlier test results any time via the edit history of the comment.

I am not sure how much effort it would be to resurface that feature. The code is there, but wiring might be a bumpy ride.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants