Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull changes from main to v0.2.0 #121

Merged
merged 12 commits into from
May 2, 2023
Merged

Pull changes from main to v0.2.0 #121

merged 12 commits into from
May 2, 2023

Conversation

fu5ha
Copy link
Member

@fu5ha fu5ha commented May 2, 2023

Does what it says on the tin

davidpdrsn and others added 11 commits March 20, 2023 12:59
### Checklist

* [x] I have read the [Contributor Guide](../../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

Updates mirror-mirror-macros to syn 2.0.
### Checklist

* [x] I have read the [Contributor Guide](../../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

Also update syn to 2.0 in mirror-mirror

I forgot about `SimpleTypeName`. Also bumped speedy.
### Checklist

* [x] I have read the [Contributor Guide](../../CONTRIBUTING.md)
* [x] I have read and agree to the [Code of
Conduct](../../CODE_OF_CONDUCT.md)
* [x] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

Due to some internal dependency clashes, I want to downgrade the minimum
requirement of the `speedy` dependency. Any top-level user can still
specify to use 0.8.6 as that is a non-breaking change.
Specifies a constant seed that allows cross-process-deterministic hashes
to be generated.

Using this static random state in `HashMap` and the generation of
`NodeId` allows this crate to generate predictable trees when
serializing/deserializing encoding/decoding hashing.

See:
https://docs.rs/ahash/latest/ahash/random_state/struct.RandomState.html

<img width="1002" alt="image"
src="https://user-images.githubusercontent.com/19969910/229842869-e4b32c23-1335-4af4-80ca-ae3c7c7d217f.png">

Currently, the hasher is seeded first time when the AHasher is
constructed.
### Checklist

* [X] I have read the [Contributor Guide](../../CONTRIBUTING.md)
* [X] I have read and agree to the [Code of
Conduct](../../CODE_OF_CONDUCT.md)
* [X] I have added a description of my changes and why I'd like them
included in the section below

### Description of Changes

I have a use case where I need to serialize just a scalar, so can't use
`Value`
but `ScalarOwned` previously wasn't serializable.
@fu5ha fu5ha requested a review from davidpdrsn as a code owner May 2, 2023 13:36
@fu5ha fu5ha merged commit 6dccf03 into v0.2.0 May 2, 2023
@fu5ha fu5ha deleted the main-to-0.2 branch May 2, 2023 13:45
davidpdrsn added a commit that referenced this pull request Mar 4, 2024
Does what it says on the tin

---------

Co-authored-by: David Pedersen <[email protected]>
Co-authored-by: Max de Danschutter <[email protected]>
Co-authored-by: Timon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants