Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1420] Synchronizer.proposeShielding crashes when there are insuffic… #1424

Merged
merged 1 commit into from
May 15, 2024
Merged

[#1420] Synchronizer.proposeShielding crashes when there are insuffic… #1424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ and this library adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

# Unreleased

## Fixed
- The backend method proposeShielding checks the pointer for a null value before attempting to construct the Data with it. Without this check, proposeShielding would crash when there were either zero funds to shield or when the amount was less than the threshold defined by the client.

# 2.1.5 - 2024-04-18

## Changed
Expand Down
8 changes: 6 additions & 2 deletions Sources/ZcashLightClientKit/Rust/ZcashRustBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,11 +752,15 @@ struct ZcashRustBackend: ZcashRustBackendWelding {
)

guard let proposal else {
throw ZcashError.rustShieldFunds(lastErrorMessage(fallback: "`proposeShielding` failed with unknown error"))
throw ZcashError.rustShieldFunds(lastErrorMessage(fallback: "Failed with nil proposal."))
}

defer { zcashlc_free_boxed_slice(proposal) }


guard proposal.pointee.ptr != nil else {
throw ZcashError.rustShieldFunds(lastErrorMessage(fallback: "Failed with nil pointer."))
}

return try FfiProposal(contiguousBytes: Data(
bytes: proposal.pointee.ptr,
count: Int(proposal.pointee.len)
Expand Down
Loading