Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for deriving addresses from UFVK and UIVK values to the derivation module. #174

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Dec 9, 2024

No description provided.

Copy link
Collaborator

@LukasKorba LukasKorba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom force-pushed the ua_derivation branch 2 times, most recently from 85e5525 to eb711f0 Compare December 9, 2024 18:24
@nuttycom nuttycom changed the base branch from feature/proposal_to_pczt to release/0.12.0 December 9, 2024 18:24
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK with non-blocking comments.

Co-authored-by: Daira-Emma Hopwood <[email protected]>
@nuttycom nuttycom merged commit 9dd0714 into release/0.12.0 Dec 10, 2024
@nuttycom nuttycom deleted the ua_derivation branch December 10, 2024 00:38
@@ -6,6 +6,10 @@ and this library adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

### Added
- `zcashlc_derive_address_ufvk`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should have from_ added to the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants