Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep BLOCKS_METADATA_BUFFER_SIZE the same as current SYNC_BATCH_SIZE #1555

Open
HonzaR opened this issue Aug 7, 2024 · 0 comments
Open

Keep BLOCKS_METADATA_BUFFER_SIZE the same as current SYNC_BATCH_SIZE #1555

HonzaR opened this issue Aug 7, 2024 · 0 comments

Comments

@HonzaR
Copy link
Contributor

HonzaR commented Aug 7, 2024

Is your feature request related to a problem? Please describe.

We'd like to follow up on this issue, where we defined the ideal situation - using BLOCKS_METADATA_BUFFER_SIZE the same size as the sync batch. We use SYNC_BATCH_SIZE and then SYNC_BATCH_SMALL_SIZE for the sandblasting period, so the BLOCKS_METADATA_BUFFER_SIZE should reflect this.

Currently, we only raised the BLOCKS_METADATA_BUFFER_SIZE to 1000, which brings great sync machine speed up (about 50%) and still works well for the sandblasting period.

Describe the solution you'd like

Alternatives you've considered

Additional context
HonzaR added a commit that referenced this issue Aug 7, 2024
@HonzaR
[#1364] Increase BLOCKS_METADATA_BUFFER_SIZE
653bc15 
- Closes #1364
- Filed another related improvement issue #1555
- Changelog update
HonzaR added a commit that referenced this issue Aug 7, 2024
@HonzaR
[#1364] Increase BLOCKS_METADATA_BUFFER_SIZE
b9eee46 
- Closes #1364
- Filed another related improvement issue #1555
- Changelog update
@HonzaR HonzaR mentioned this issue Aug 7, 2024
Merged
13 tasks
HonzaR added a commit that referenced this issue Aug 7, 2024
@HonzaR
[#1364] Increase BLOCKS_METADATA_BUFFER_SIZE
6ad1021 
- Closes #1364
- Filed another related improvement issue #1555
- Changelog update
HonzaR added a commit that referenced this issue Aug 8, 2024
@HonzaR
[#1364] Increase BLOCKS_METADATA_BUFFER_SIZE
9259f8e 
* [#1364] Increase BLOCKS_METADATA_BUFFER_SIZE

- Closes #1364
- Filed another related improvement issue #1555
- Changelog update

* Improve changelog statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HonzaR