Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fetch UTXOs error handling #1539

Closed
HonzaR opened this issue Jul 26, 2024 · 0 comments · Fixed by #1540
Closed

Improve fetch UTXOs error handling #1539

HonzaR opened this issue Jul 26, 2024 · 0 comments · Fixed by #1540
Assignees
@HonzaR
Labels
bug Something isn't working

Comments

@HonzaR
Copy link
Contributor

HonzaR commented Jul 26, 2024

Describe the issue

After we analyzed #1538 we found a few parts to improve:

  • set missing start height to fetch utxo gRPC request
  • report repeatedly failing utxo error to upstream logic
@HonzaR HonzaR added the bug Something isn't working label Jul 26, 2024
@HonzaR HonzaR self-assigned this Jul 26, 2024
HonzaR added a commit that referenced this issue Jul 26, 2024
@HonzaR
[#1539] Use omitted startHeight
55746a4
HonzaR added a commit that referenced this issue Jul 26, 2024
@HonzaR
[#1539] Throw utxos fetch error
4a14f10
@HonzaR HonzaR mentioned this issue Jul 26, 2024
Merged
13 tasks
HonzaR added a commit that referenced this issue Aug 1, 2024
@HonzaR
[#1539] Improve fetch UTXOs error handling
a637ad5 
* [#1539] Use omitted startHeight

* [#1539] Throw utxos fetch error

* Changelog update

* Improve fetch UTXOs error handling

- processUtxoResult now throws the RuntimeException instead of swallowing it and reporting just the false result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HonzaR HonzaR

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1539] Improve fetch UTXOs error handling Electric-Coin-Company/zcash-android-wallet-sdk
1 participant
@HonzaR