Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations in texts #534

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

roewenstrunk
Copy link
Member

Description, Context and related Issue

This PR contains fixes for annotation icons in text view

Refs #460

How Has This Been Tested?

Tested with Open Faust data

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Overview

@roewenstrunk
Copy link
Member Author

@feuerbart , I created an issue in Open Faust (see https://git.uni-paderborn.de/kio/open-faust/-/issues/3). You should add some extra CSS to your edition specific file.

@roewenstrunk roewenstrunk added this to the 1.0.0 milestone Jan 22, 2025
@peterstadler peterstadler linked an issue Jan 23, 2025 that may be closed by this pull request
Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activating the annotations now displays a tooltip symbol and hovering over it now triggers the tooltip to show, but

  1. you can't hide the annotation symbol anymore. Both the global as well as the per view "show/hide annotations" do not work
  2. extra vertical space is introduced in the second column
    Bildschirmfoto 2025-01-23 um 17 40 23

@roewenstrunk
Copy link
Member Author

The spacing in the Open Faust data is because of CSS issues in the edition, as I wrote earlier.
The "show/hide" of annotations is now fixed.
@peterstadler

@feuerbart
Copy link
Contributor

implemented the css, works fine with the OPERA-table-layout, thanks @roewenstrunk

Bildschirmfoto 2025-01-24 um 10 57 42

but when i switch to Edirom default layout, the annotation icon is placed below the line:

Bildschirmfoto 2025-01-24 um 10 58 19

seems to be connected to div { display: block; ... }.
playing around with display: inline-block; and defining some width, i could make it work, but i'm not sure if that is a good solution.

@roewenstrunk
Copy link
Member Author

Hi @feuerbart , I fixed the inline display and some width issues with visibility: hidden. Could you please test?
Hi @peterstadler , could you please accept the changes, you requested?

@feuerbart
Copy link
Contributor

Bildschirmfoto 2025-01-30 um 18 24 13

still breaking before the annotation icon. the preceding <div class="l"> has no block defined so the browser defines it as display: block; what breaks after the element. setting that manually to display: inline-block; fixes the icons position but will break the lines layout.
have done some research but not yet found a solution that will not break after the div for other divs but not for spans.

@feuerbart
Copy link
Contributor

i just tested all the options for display with divs, none is a solution.
but moving the <span class="note">... inside the <div class="l">... did it. is there a reason why it is not already there?
the onmouseovers won't work like that but that could be fixed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

[BUG] annotations display in text edition
3 participants