Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow response when changing number of points of a curve #5327

Closed
1 task done
fhpage opened this issue Jul 26, 2024 · 10 comments · Fixed by #5333
Closed
1 task done

Slow response when changing number of points of a curve #5327

fhpage opened this issue Jul 26, 2024 · 10 comments · Fixed by #5333
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour

Comments

@fhpage
Copy link

fhpage commented Jul 26, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Changing the number of points on a curve using either the wheel or touch commands is very slow to respond to changes. Can take several seconds (3-5). Using the roller wheel, have to turn one click and wait several seconds. Tested with 2.10.0, 2.10.2, 2.9.4. Also tested with 2 TX16S and one X10S. Not an issue with OpenTX on X12S.

Expected Behavior

The GUI should be able to follow the number of wheel clicks without stalling...

Steps To Reproduce

Use scroll (roller) wheel to change number of points on a curve.

Version

2.10.2

Transmitter

FrSky X10 / X10S (ACCST), RadioMaster TX16S / TX16SMK2

Operating System (OS)

No response

OS Version

No response

Anything else?

No response

@fhpage fhpage added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jul 26, 2024
@TomasJot
Copy link

No problems on 2.11.0 - changing number of points takes < 0.5s

@philmoz
Copy link
Collaborator

philmoz commented Jul 27, 2024

This is the performance issue with the text input fields in Lvgl.

@pfeerick - is it worth trying to back port the workaround from 2.11?

@fhpage
Copy link
Author

fhpage commented Jul 27, 2024

If 2.11 is a ways out to being released, a back port would be appreciated. This impacts everyone that uses curves. It is frustrating to use as is. Best alternative now is to use companion....

@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour and removed triage Bug report awaiting review / sorting labels Jul 27, 2024
@pfeerick
Copy link
Member

pfeerick commented Jul 27, 2024

Only you can answer that question Phil as you know how much code change is needed to make it work. I wonder if it is worth detaching that field so it doesn't "live update" on every field change, but rather on exit? Thus you only get one refresh update delay, not multiple as the values change? i.e popup menu instead of textedit field?

@philmoz
Copy link
Collaborator

philmoz commented Jul 27, 2024

It's also slow when changing from 'Standard' to 'Custom' because the point list gets rebuilt.

Back porting the 2.11 code would be a significant change (and affects all pages with text/number entry fields).
Since it's not technically a bug fix I wasn't sure about trying to retro fit into 2.10.

@pfeerick
Copy link
Member

pfeerick commented Jul 27, 2024

That was what I thought might be the case... What about simply changing the field type - to a choice/popup menu? thus it should only update once?

@philmoz
Copy link
Collaborator

philmoz commented Jul 27, 2024

That was what I thought might be the case... What about simply changing the field type - to a choice/popup menu? thus it should only update once?

That's probably the best option for 2.10.

I'm thinking this should also be applied to 2.11 as well for consistency.

@pfeerick
Copy link
Member

pfeerick commented Jul 28, 2024

Agreed... Plus while 2.11 performance is better there, it is still quite laggy...

@philmoz
Copy link
Collaborator

philmoz commented Sep 9, 2024

Can this be closed?

@pfeerick
Copy link
Member

pfeerick commented Sep 9, 2024

GitHub is hopeless at times... it didn't auto link/close with the PR merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants