CPN: LS and RS not set correctly after reading Model and settings from radio

[ParkerEde]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Companion

Current Behavior

in Companion in the hardware settings the sliders LS and RS not set correctly after reading Model and settings from radio

Radio:

Companion:

Expected Behavior

in the Comapnion the settings from the radio profile should be taken over correctly after reading the model and radio settings

Steps To Reproduce

• build companion with RM TX16S with current main
• make sure that in the radio under Hardware/Sliders LS and RS is assigned correctly and is no longer set to "none"
• start companion
• read modell and radio settings
• observe Radio Settings/TAB Hardware
• both Slider LS and RS are set to "none"

Version

Nightly (Please give date/commit below)

Transmitter

Radiomaster TX16S / TX16SMK2

Operating System (OS)

Windows

OS Version

Win11

Anything else?

current main

[pfeerick]

Thanks for reporting this... I hit it the other day myself when preping companion support for another radio but wasn't sure yet if I'd screwed up something in the implementation or not. 😅 edit: I forgot to mention... this only appears to effect reading... it writes fine if you set the slider setting again before writing to the radio.

…

On Wed, 30 Aug 2023, 5:31 am ParkerEde, ***@***.***> wrote: Is there an existing issue for this problem? - I have searched the existing issues What part of EdgeTX is the focus of this bug? Companion Current Behavior in Companion in the hardware settings the sliders LS and RS not set correctly after reading Model and settings from radio Expected Behavior in the Comapnion the settings from the radio profile should be taken over correctly after reading the model and radio settings Steps To Reproduce - build companion with RM TX16S with current main - make sure that in the radio under Hardware/Sliders LS and RS is assigned correctly and is no longer set to "none" - start companion - read modell and radio settings - observe Radio Settings/TAB Hardware - both Slider LS and RS are set to "none" Version Nightly (Please give date/commit below) Transmitter Radiomaster TX16S / TX16SMK2 Operating System (OS) Windows OS Version Win11 Anything else? current main — Reply to this email directly, view it on GitHub <#3982>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KIEMZ7QXPLWYMTRC3DXXY7R5ANCNFSM6AAAAAA4DNZVWU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[3djc]

Sound like the return of the vengeance of adc refactor part II

[elecpower]

and #3870 will completely break it again

[3djc]

Indeed, no point in fixing before 3870 gets in, and maybe try to see if we can ease companion task by parsing hardware definition data for it (until full yaml definitions get worked on)

[elecpower]

The Companion refactor will parse the hw json files for 2.10 onwards but as usual the biggest pain point is data mapping from the earlier hard coded definitions.

[3djc]

We are currently generating json on the fly per radio, with much more info than you need. We probably should try to make one file for companion use that gives all the info for all radio at once

[elecpower]

It is my understanding that on the fly is only a temporary method.
I have some code that handles a permanent json file per radio and ignores the entries that Companion does not care about.
I'm not in favour of an all radios config file as differences will inevitably occur in maintenance.