From 0fba24538a7ac6c96bbcd1523b138a70c4f38105 Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Wed, 21 Aug 2024 19:50:06 +0530 Subject: [PATCH 1/7] bug fix 1680 --- src/app/core/services/form/form.service.ts | 2 +- .../components/search-competency/search-competency.component.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/core/services/form/form.service.ts b/src/app/core/services/form/form.service.ts index aaced72f..e15c4e82 100644 --- a/src/app/core/services/form/form.service.ts +++ b/src/app/core/services/form/form.service.ts @@ -83,7 +83,7 @@ export class FormService { await entityList.map((entityName)=>{ if(Array.isArray(existingData[entityName])){ existingData[entityName] = existingData[entityName].map((data)=>{ - return { label : data.label, value : data.value == 'other' ? data.label : data.value } + return { label : data.label, value : data.value == 'other' ? data.label : data.value, type: data.value } }) } }) diff --git a/src/app/shared/components/search-competency/search-competency.component.ts b/src/app/shared/components/search-competency/search-competency.component.ts index 22956a95..51c885e4 100644 --- a/src/app/shared/components/search-competency/search-competency.component.ts +++ b/src/app/shared/components/search-competency/search-competency.component.ts @@ -52,7 +52,7 @@ export class SearchCompetencyComponent implements OnInit { } clearAll(){ - this.selectedOptions = []; + this.selectedOptions = this.selectedOptions.filter(option => option.type === 'other'); } closePopover() { From 832690ad74ad1080323d1bbb1c1b41a132930684 Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Wed, 21 Aug 2024 19:51:11 +0530 Subject: [PATCH 2/7] bug fix 1708 --- forms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/forms.json b/forms.json index 3f9974e6..4fc8eebb 100644 --- a/forms.json +++ b/forms.json @@ -706,7 +706,7 @@ "searchData": [], "maxCount": "MAX_MENTEE_ENROLLMENT_COUNT", "labelForListButton": "View Mentee List", - "labelForAddButton": "Add New Mentee", + "labelForAddButton": "Add Mentee", "filters": { "entity_types": [ { From 4a2fa1673544b127ba71eb64c6e19a9ab57d8cee Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Thu, 22 Aug 2024 10:07:15 +0530 Subject: [PATCH 3/7] bug fix 1680 --- .../search-and-select/search-and-select.component.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/shared/components/search-and-select/search-and-select.component.ts b/src/app/shared/components/search-and-select/search-and-select.component.ts index f587d752..da1e21ec 100644 --- a/src/app/shared/components/search-and-select/search-and-select.component.ts +++ b/src/app/shared/components/search-and-select/search-and-select.component.ts @@ -118,7 +118,8 @@ export class SearchAndSelectComponent implements OnInit, ControlValueAccessor { handler: (alertData) => { let obj = { label: alertData.name, - value: alertData.name + value: alertData.name, + type: "other" }; this.selectedData.push(obj); this.selectedChips.push(obj.value) From a5714908b5c66eda97534278b596166353f2f424 Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Thu, 22 Aug 2024 15:18:58 +0530 Subject: [PATCH 4/7] bug fix 1715 --- src/app/core/services/profile/profile.service.ts | 1 + .../mentor-search-directory.page.html | 6 +++--- .../mentor-search-directory/mentor-search-directory.page.ts | 3 +++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/app/core/services/profile/profile.service.ts b/src/app/core/services/profile/profile.service.ts index 2c4e5cdb..bf513f29 100644 --- a/src/app/core/services/profile/profile.service.ts +++ b/src/app/core/services/profile/profile.service.ts @@ -232,6 +232,7 @@ export class ProfileService { } catch (error) { showLoader ? await this.loaderService.stopLoader() : ''; + return error } } diff --git a/src/app/pages/mentor-search-directory/mentor-search-directory.page.html b/src/app/pages/mentor-search-directory/mentor-search-directory.page.html index 4f6f9a39..f95b8488 100644 --- a/src/app/pages/mentor-search-directory/mentor-search-directory.page.html +++ b/src/app/pages/mentor-search-directory/mentor-search-directory.page.html @@ -73,9 +73,9 @@ - {{"MENTOR_SEARCH_RESULT" | translate}} "{{searchText}}" + {{"MENTOR_SEARCH_RESULT" | translate}} "{{searchText}}" -
+
{{totalCount}} {{"SEARCH_RESULT" | translate}}
@@ -91,7 +91,7 @@ -
+
\ No newline at end of file diff --git a/src/app/pages/mentor-search-directory/mentor-search-directory.page.ts b/src/app/pages/mentor-search-directory/mentor-search-directory.page.ts index 089d38c6..9067ce39 100644 --- a/src/app/pages/mentor-search-directory/mentor-search-directory.page.ts +++ b/src/app/pages/mentor-search-directory/mentor-search-directory.page.ts @@ -185,6 +185,9 @@ export class MentorSearchDirectoryPage implements OnInit { this.isOpen = false; this.data = data.result.data; this.totalCount = data.result.count; + }else{ + this.data = []; + this.totalCount = []; } } From 0ae394b0696bc872ed96a69a90e79ec47721b54c Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Thu, 22 Aug 2024 16:02:01 +0530 Subject: [PATCH 5/7] bug fix 1705 --- src/app/modules/auth/register/register.page.ts | 17 +++++++++-------- .../auth/reset-password/reset-password.page.ts | 17 +++++++++-------- .../change-password/change-password.page.ts | 17 +++++++++-------- 3 files changed, 27 insertions(+), 24 deletions(-) diff --git a/src/app/modules/auth/register/register.page.ts b/src/app/modules/auth/register/register.page.ts index ba6f9e53..3a792e87 100644 --- a/src/app/modules/auth/register/register.page.ts +++ b/src/app/modules/auth/register/register.page.ts @@ -9,6 +9,7 @@ import { ActivatedRoute, Router } from '@angular/router'; import { CommonRoutes } from 'src/global.routes'; import { TranslateService } from '@ngx-translate/core'; import { ProfileService } from 'src/app/core/services/profile/profile.service'; +import { environment } from 'src/environments/environment'; @Component({ selector: 'app-register', @@ -60,13 +61,13 @@ export class RegisterPage implements OnInit { position: 'floating', errorMessage:{ required: "Enter password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password?.minLength +" characters." : "Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password?.minLength +" characters." : "Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, validators: { required: true, - minLength:window['env']?.password?.minLength ? window['env']?.password?.minLength: 8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password?.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength:environment?.password?.minLength ? environment?.password?.minLength: 8, + pattern: environment?.password?.rejectPattern ? environment?.password?.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", }, }, { @@ -78,13 +79,13 @@ export class RegisterPage implements OnInit { position: 'floating', errorMessage:{ required: "Re-enter password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password.minLength+" characters.":"Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password.minLength+" characters.":"Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, validators: { required: true, - minLength: window['env']?.password?.minLength ? window['env']?.password.minLength:8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength: environment?.password?.minLength ? environment?.password.minLength:8, + pattern: environment?.password?.rejectPattern ? environment?.password.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", } } ] diff --git a/src/app/modules/auth/reset-password/reset-password.page.ts b/src/app/modules/auth/reset-password/reset-password.page.ts index a4cc56b8..6eaf40e7 100644 --- a/src/app/modules/auth/reset-password/reset-password.page.ts +++ b/src/app/modules/auth/reset-password/reset-password.page.ts @@ -6,6 +6,7 @@ import { Router } from '@angular/router'; import { ProfileService } from 'src/app/core/services/profile/profile.service'; import { ToastService } from 'src/app/core/services'; import { TranslateService } from '@ngx-translate/core'; +import { environment } from 'src/environments/environment'; @Component({ selector: 'app-reset-password', @@ -40,14 +41,14 @@ export class ResetPasswordPage implements OnInit { type: 'password', errorMessage:{ required: "Enter new password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password?.minLength+" characters.":"Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password?.minLength+" characters.":"Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, position: 'floating', validators: { required: true, - minLength:window['env']?.password?.minLength? window['env']?.password?.minLength: 8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password?.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength:environment?.password?.minLength? environment?.password?.minLength: 8, + pattern: environment?.password?.rejectPattern ? environment?.password?.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", }, }, { @@ -58,14 +59,14 @@ export class ResetPasswordPage implements OnInit { type: 'password', errorMessage:{ required: "Re-enter new password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password?.minLength+" characters.":"Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password?.minLength+" characters.":"Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, position: 'floating', validators: { required: true, - minLength:window['env']?.password?.minLength? window['env']?.password?.minLength: 8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password?.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength:environment?.password?.minLength? environment?.password?.minLength: 8, + pattern: environment?.password?.rejectPattern ? environment?.password?.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", }, }, ], diff --git a/src/app/pages/change-password/change-password.page.ts b/src/app/pages/change-password/change-password.page.ts index afed5970..2a0e408a 100644 --- a/src/app/pages/change-password/change-password.page.ts +++ b/src/app/pages/change-password/change-password.page.ts @@ -3,6 +3,7 @@ import { TranslateService } from '@ngx-translate/core'; import * as _ from 'lodash'; import { AuthService, ToastService } from 'src/app/core/services'; import { DynamicFormComponent, JsonFormData } from 'src/app/shared/components'; +import { environment } from 'src/environments/environment'; @Component({ selector: 'app-change-password', @@ -43,14 +44,14 @@ public headerConfig: any = { type: 'password', errorMessage:{ required: "Enter new password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password?.minLength+" characters.":"Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password?.minLength+" characters.":"Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, position: 'floating', validators: { required: true, - minLength:window['env']?.password?.minLength? window['env']?.password?.minLength: 8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password?.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength:environment?.password?.minLength? environment?.password?.minLength: 8, + pattern: environment?.password?.rejectPattern ? environment?.password?.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", }, }, { @@ -61,14 +62,14 @@ public headerConfig: any = { type: 'password', errorMessage:{ required: "Re-enter new password", - minlength:window['env']?.password?.minLength ? "Please enter minimum " + window['env']?.password?.minLength+" characters.":"Please enter minimum 8 characters.", - pattern: window['env']?.password?.errorMessage ? window['env']?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", + minlength:environment?.password?.minLength ? "Please enter minimum " + environment?.password?.minLength+" characters.":"Please enter minimum 8 characters.", + pattern: environment?.password?.errorMessage ? environment?.password?.errorMessage :"Only letters, numbers,!@#%$&()-`.+,/\" are allowed", }, position: 'floating', validators: { required: true, - minLength:window['env']?.password?.minLength? window['env']?.password?.minLength: 8, - pattern: window['env']?.password?.regexPattern ? window['env']?.password?.regexPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", + minLength:environment?.password?.minLength? environment?.password?.minLength: 8, + pattern: environment?.password?.rejectPattern ? environment?.password?.rejectPattern :"^[a-zA-Z0-9!@#%$&()\\-`.+,/\"]*$", }, }, ], From ce4e01f3cca0a071bb3c0b93624370b95d8e49f1 Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Thu, 22 Aug 2024 16:04:18 +0530 Subject: [PATCH 6/7] bug fix 1693 --- src/app/pages/create-session/create-session.page.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/pages/create-session/create-session.page.ts b/src/app/pages/create-session/create-session.page.ts index 60b7e3ba..5f967e15 100644 --- a/src/app/pages/create-session/create-session.page.ts +++ b/src/app/pages/create-session/create-session.page.ts @@ -260,7 +260,7 @@ export class CreateSessionPage implements OnInit { this.formData.controls[i].id = this.id; if(this.formData.controls[i].meta.multiSelect){ this.formData.controls[i].meta.searchData = existingData[this.formData.controls[i].name] - this.formData.controls[i].value = this.formData.controls[i].meta.searchData.map(obj => obj.id || obj.value); + this.formData.controls[i].value = this.formData.controls[i].meta.searchData ? this.formData.controls[i].meta.searchData.map(obj => obj.id || obj.value) : []; } else { this.formData.controls[i].meta.searchData = [{ label: `${existingData.mentor_name}, ${existingData.organization.name}`, From 8a066ba0a0a0066e2938c10f7b4d8133fc2bd1cf Mon Sep 17 00:00:00 2001 From: Rahul K R Date: Thu, 22 Aug 2024 16:09:25 +0530 Subject: [PATCH 7/7] bug fix 1715 --- .../components/manage-session/manage-session.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/modules/admin/components/manage-session/manage-session.component.html b/src/app/modules/admin/components/manage-session/manage-session.component.html index 1c8e6ccf..380b911b 100644 --- a/src/app/modules/admin/components/manage-session/manage-session.component.html +++ b/src/app/modules/admin/components/manage-session/manage-session.component.html @@ -42,7 +42,7 @@
-
+