Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words With Friends Facebook app just shows a spinning 'W' tile #3048

Open
chrisco23 opened this issue Jan 29, 2025 · 7 comments
Open

Words With Friends Facebook app just shows a spinning 'W' tile #3048

chrisco23 opened this issue Jan 29, 2025 · 7 comments
Labels
broken site bug Chrome MDFP Multi-domain first parties: lists of domains that should be treated as related to each other MV3 Manifest V3-specific issue

Comments

@chrisco23
Copy link

Just tracked this down turning off my extensions one by one. Sure enough turning off Privacy Badger solved it. I investigate a little more and found that I can exclude) apps.facebook.com and still have Privacy Badger on.

That's fine for me for now but thought you might want to know, as who knows what else broke on Jan 17.

@ghostwords

This comment has been minimized.

@ghostwords ghostwords added question Further information is requested broken site labels Jan 29, 2025
@chrisco23

This comment has been minimized.

@ghostwords

This comment has been minimized.

@ghostwords ghostwords changed the title Jan 17 release breaks playing WWF Facebook app. Words With Friends Facebook app just shows a spinning 'W' tile Jan 29, 2025
@ghostwords ghostwords added bug Chrome MV3 Manifest V3-specific issue and removed question Further information is requested labels Jan 29, 2025
@ghostwords
Copy link
Member

ghostwords commented Jan 29, 2025

Previously: #3027 where vscode.dev and visualstudio.com belong to the same MDFP list, but our DNR rules somehow blocked a subdomain of visualstudio.com on vscode.dev.

Here, facebook.net and facebook.com are similarly on the same MDFP list, but our DNR rules somehow block connect.facebook.net on apps.facebook.com.

Here is the relevant DNR block rule that ends up blocking connect.facebook.net:

{
    "action": {
        "type": "block"
    },
    "condition": {
        "domainType": "thirdParty",
        "excludedInitiatorDomains": [
            "meta.com",
            "facebook.com",
            "instagram.com",
            "messenger.com",
            "threads.net",
            "workplace.com",
            "oculus.com",
            "oculuscdn.com",
            "oculusrift.com",
            "oculusvr.com",
            "powersunitedvr.com",
            "cdninstagram.com",
            "facebook.net",
            "fbcdn.com",
            "fbcdn.net",
            "fbsbx.com"
        ],
        "requestDomains": [
            "facebook.net"
        ]
    },
    "id": 1280,
    "priority": 1
}

@ghostwords
Copy link
Member

OK, so the problem here is that Chrome sees a Zynga sub frame (wwf.zynga.com) attempting to load something from connect.facebook.net, and apparently excludedInitiatorDomains consider the immediate parent frame to be the initiator, not the top-level document. Since we mean to check third party-ness against the top-level document, not the sub frame, and since zynga.com is not part of Facebook's MDFP list, we end up blocking connect.facebook.net on apps.facebook.com.

@ghostwords ghostwords added the MDFP Multi-domain first parties: lists of domains that should be treated as related to each other label Jan 29, 2025
@chrisco23
Copy link
Author

chrisco23 commented Jan 29, 2025 via email

@ghostwords
Copy link
Member

We're butting up against a Chrome Manifest V3 design problem. This is definitely a Privacy Badger bug, unfortunately not limited to Facebook. We should have a workaround for it in the future, but yeah, I would just keep PB disabled on apps.facebook.com for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken site bug Chrome MDFP Multi-domain first parties: lists of domains that should be treated as related to each other MV3 Manifest V3-specific issue
Projects
None yet
Development

No branches or pull requests

2 participants