Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the source code #4

Closed
minecrawler opened this issue Jun 30, 2017 · 3 comments
Closed

State of the source code #4

minecrawler opened this issue Jun 30, 2017 · 3 comments
Assignees
Milestone

Comments

@minecrawler
Copy link
Collaborator

At the moment, mics is advertise as

Intuitive mixins for ES6 classes

However, in its own code, it uses a wild mix of outdated syntax, like var and not even available syntax (at least on NodeJS), like export function. I think, it would be better to choose one. Personally, I would prefer ES6 as is available on NodeJS LTS (v6 atm), as it has a lot of benefits, especially for static analysis, and gets rid of the dependency on a transpiler for deployment.

Additionally, there is no linting available, and the code seems to not follow any guidelines. E.g. sometimes there are multiple variables declared per var statement, sometimes there are multiple consecutive var statements. I would suggest using airbnb's coding guidelines in order to improve the code quality and consistency.

After #2 is finished, I could run the code through WebStorm code analysis and fix the syntax one way or the other, if desired. It's only a few lines, so not too much trouble, actually :)

@Download
Copy link
Owner

I'm all for it. However the code should continue to work on ES5 platforms. (I see IE11 as the baseline atm). Oh and it should stay small! 👍

@Download Download added this to the 1.0 milestone Jun 30, 2017
@Download
Copy link
Owner

Download commented Jul 3, 2017

#9

@Download
Copy link
Owner

Download commented Jul 3, 2017

See specific issues for the progress on the state of the source code.

@Download Download closed this as completed Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants