Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded libdasm library #24

Open
xambroz opened this issue Mar 26, 2018 · 1 comment
Open

embedded libdasm library #24

xambroz opened this issue Mar 26, 2018 · 1 comment

Comments

@xambroz
Copy link

xambroz commented Mar 26, 2018

Hello,
the libemu library contains embedded libdasm library. There are 2 known issues about that:

  1. obsolete version
    the version of the libdasm library embedded in libemu is obsolete version 1.4 ... should be updated.

  2. ambiguous licensing
    There are some legal concerns, about the code od libdasm.h libdasm.c.
    Readme of the original libdasm claims this code is in public domain, but that file is not included in the embedding to libemu.
    There is in contradiction with the original public domain claim and the copyright mark (c) in the code itself. On one hand it is claiming it is "public domain" on the other hand there is copyright notice in the code without any specification of the license - which by many jurisdictions means actually that the code takes all the protections granted by the legislation to protect intellectual properties.

Personally I believe it would be best to unbundle and depend on the system library of libdasm.

Michal Ambroz

@xambroz
Copy link
Author

xambroz commented Apr 2, 2018

Please consider unbundling the libdasm library and use the current 1.6 release of the libdasm
https://github.com/jtpereyda/libdasm/releases

Related pull request to unbundle the libdasm library (and allow update to 1.6) #25

Best regards
Michal Ambroz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant