Screen and collect screens but subsequent collections are not made

[rtuck99]

Discovered during testing in #697

Screen and collect is screening, but not collecting, the request never gets as far as hyperion.

See e.g. https://ispyb.diamond.ac.uk/dc/visit/mx23694-123/id/16086403
which is the screening collection, but the full collection was not then performed

2024-12-05 15:13:24,656 INFO  [server/[email protected]] gda.px.unattendeddatacollection.UDCRunner - Performing instruction: {"collect":{"collection":[{"chi":0.0,"experiment_type":"Characterizati
on","comment":"screening","distance":201.8,"exposure_time":0.03000000000000001,"kappa":0.0,"number_of_images":150,"omega_increment":0.1,"omega_overlap":0.0,"omega_start":0.0,"phi_increment":0.0,"phi_overlap":
0.0,"phi_start":0.0,"resolution":1.5,"scan_axis":"omega","transmission":0.1,"two_theta":0.0,"wavelength":0.9762499999999998,"centring_mode":"XRAY"}],"sample":{"id":6036094,"name":"ins_6","container":2,"positi
on":6,"subLocation":null,"loopType":null},"prefix":"/dls/i03/data/2024/mx23694-123/auto/screen/TestInsulin/ins_6/ins_6","recipe_limits":{"transmission":{"max":0.1},"distance":{"min":150.0,"max":800.0},"wavele
ngth":{"min":0.52,"max":2.06675},"resolution":{"min":0.64,"max":30.0},"exposure_time":{"min":0.004,"max":1.0},"priority":{"min":-99}}}}

after performing the screening collection, gda then logs:

2024-12-05 15:14:51,159 INFO  [server/[email protected]] datacollection.HandleCollectRequestSupport - HandleCollectRequest_Ended.
2024-12-05 15:14:51,159 INFO  [server/[email protected]] gda.px.unattendeddatacollection.UDCRunner - Asking for instruction
2024-12-05 15:14:51,159 INFO  [server/[email protected]] gda.px.unattendeddatacollection.UDCRunner - Determining blsampleid of current sample
2024-12-05 15:14:51,159 INFO  [server/[email protected]] unattended_data_collection.UDCUtilities - Couldn't getBlsampleidOfCurrentLoadedSample - no sample loaded
2024-12-05 15:14:51,159 INFO  [server/[email protected]] gda.px.unattendeddatacollection.UDCRunner - Current blsampleid is: null
2024-12-05 15:14:51,160 INFO  [server/[email protected]] gda.px.unattendeddatacollection.UDCInstructionRequester - Send currentBeamline: i03, currentSampleID: null, currentWavelength: 0.976253543307 to: http://agamemnon.diamond.ac.uk/getnextcollect/i03/?blsampleid=null

And then immediately moves on to the next sample

Suspect this is because self.sampleProvider.setSample(sample) in robot_load_and_centre/hyperion.py is never called when using load_centre_collect - the sampleProvider sample is then ultimately used by UDCRunner to fetch the next instruction but this is always null because it is never set.

Acceptance Criteria

• Screen and collect works when load_centre_collect_full plan is used in hyperion

[rtuck99]

Raised gerrit https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/43072

[olliesilvester]

I've +1'd the gerrit change, although the build failed because of an 'Unknown Error'.

Also, this seems like one we should test on the beamline before putting the GDA change on live, so let's leave this issue open until it's tested

[DominicOram]

As seen in #769, there was also an issue where we weren't passing Characterisation through in GDA as the experiment type. This is now fixed on the beamline.

To confirm fix:

• Confirm i03 is doing a good S+C on each sample
• Confirm any code around this on i03's deployed GDA is committed - no need for it to be in gerrit

[DominicOram]

Closing this as it has been clearly working on the beamline for a while now. Can re-open if there's a new issue