Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting additional directories and environment variables to Helm chart #790

Open
DiamondJoseph opened this issue Jan 20, 2025 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers helm chart

Comments

@DiamondJoseph
Copy link
Contributor

DiamondJoseph commented Jan 20, 2025

This would be to e.g. mount configuration for detectors.
This should probably be in the form of allowing the definition of additional configmaps to mount to the pod.

Acceptance Criteria

  • Specific criteria that will be used to judge if the issue is fixed
@DominicOram
Copy link
Contributor

FYI @noemifrisina we also need this in MX + Crystallography to mount lookup tables. Though the more permanent service that @Relm-Arrowny is working on would help this.

@callumforrester callumforrester added enhancement New feature or request helm chart good first issue Good for newcomers labels Feb 13, 2025
@callumforrester
Copy link
Contributor

So I think it's important to say from the top that we're reluctant to introduce dependencies on /dls_sw that we then have to get rid of later. I'm more comfortable with it now that we have a solid plan to replace them. On the other hand it might be a better use of the core team's time to help @Relm-Arrowny.

@DominicOram @noemifrisina and @olliesilvester please could you provide more details on how much this is blocking you?

@Relm-Arrowny
Copy link
Contributor

I am just on the starting block on this, here is what I am planing to do if it make any sense.

@noemifrisina
Copy link

noemifrisina commented Feb 13, 2025

At the moment, the main issue for me is that devices relying on lookup tables - which live in /dls_sw/ - can't connect on the blueapi running on the beamline cluster. For the moment there's more work to do first on the i19 side, so it's not blocking much, it may become more problematic as devices and plans are added.

@Relm-Arrowny Just so I'm caught up, what is the service you're working on?

@olliesilvester
Copy link

I'm likely to run into this in the next 6 weeks, but would be happy to help with @Relm-Arrowny 's service rather than do a temporary solution

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Just so I'm caught up, what is the service you're working on?

I am planing to do something similar to this https://github.com/DiamondLightSource/daq-config-server. I have not really got started other than look into what I need to do, so that it will work with supergraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers helm chart
Projects
None yet
Development

No branches or pull requests

6 participants