Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: determine negotiated value for MultifragmentUpdate::max_request_size #318

Open
elmarco opened this issue Dec 4, 2023 · 0 comments
Open

server: determine negotiated value for MultifragmentUpdate::max_request_size #318

elmarco opened this issue Dec 4, 2023 · 0 comments
Labels
A-server Area: RDP server enhancement New feature or request help wanted Extra attention is needed investigate Further investigation required

Comments

@elmarco
Copy link
Contributor

elmarco commented Dec 4, 2023 •
edited
Loading

IronRDP/crates/ironrdp-server/src/capabilities.rs

Line 77 in f5f5e9c

max_request_size: u32::MAX,

is rejected by msctc, the client will disconnect. (presumably, it tries to allocate that much buffer space upfront)

The value was also adjusted in FreeRDP: FreeRDP/FreeRDP#1313

There doesn't seem to be a way to negotiate that value with the client beforehand.
@elmarco elmarco mentioned this issue Dec 4, 2023
Merged
@CBenoit CBenoit added enhancement New feature or request help wanted Extra attention is needed A-server Area: RDP server labels Dec 4, 2023
elmarco added a commit to elmarco/IronRDP that referenced this issue Dec 5, 2023
@elmarco
fix(server): advertize smaller FPU
b5dd802 
u32::MAX is too large for mstsc, it fails to connect.
See also: Devolutions#318

16Mb is the value use by freerdp
sample/server (FreeRDP/FreeRDP#1313) and it's
probably fine for now.

Signed-off-by: Marc-André Lureau <[email protected]>
elmarco added a commit to elmarco/IronRDP that referenced this issue Dec 5, 2023
@elmarco
fix(server): advertize smaller FPU
3f0014d 
u32::MAX is too large for mstsc, it fails to connect.
See also: Devolutions#318

16Mb is the value use by freerdp
sample/server (FreeRDP/FreeRDP#1313) and it's
probably fine for now.

Signed-off-by: Marc-André Lureau <[email protected]>
CBenoit pushed a commit that referenced this issue Dec 5, 2023
@elmarco @CBenoit
fix(server): advertize smaller FPU
b0e0dd4 
u32::MAX is too large for mstsc, it fails to connect.
See also: #318

16Mb is the value use by freerdp
sample/server (FreeRDP/FreeRDP#1313) and it's
probably fine for now.

Signed-off-by: Marc-André Lureau <[email protected]>
@CBenoit CBenoit added the investigate Further investigation required label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: RDP server enhancement New feature or request help wanted Extra attention is needed investigate Further investigation required
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elmarco @CBenoit