Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Using closing: none still shows the closing text. #89

Open
dhruvhaldar opened this issue Dec 18, 2024 · 1 comment
Open

[BUG] Using closing: none still shows the closing text. #89

dhruvhaldar opened this issue Dec 18, 2024 · 1 comment

Comments

@dhruvhaldar
Copy link

dhruvhaldar commented Dec 18, 2024

Issue

Using closing: none still shows the closing text.

Proposed Solution

Correct way is to use != instead of == in line 553.

if closing != none {
    closing = default-closing(lang_data) // Attached: Curriculum Vitae
  }
@dhruvhaldar dhruvhaldar changed the title Bug : Using closing: none still shows the closing text. [BUG] Using closing: none still shows the closing text. Dec 18, 2024
@DeveloperPaul123
Copy link
Owner

DeveloperPaul123 commented Dec 18, 2024

I believe this is intentional behavior. Passing in none should show a default closing text, but passing [] or removing the closing field completely should show nothing.

If this is not intuitive I'm happy to make API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants