Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Multithreading Implementation in MAIN.PY #60

Open
Kishore007raj opened this issue Oct 7, 2024 · 2 comments
Open

Improve Multithreading Implementation in MAIN.PY #60

Kishore007raj opened this issue Oct 7, 2024 · 2 comments

Comments

@Kishore007raj
Copy link

Bug I found:
The current implementation of the multithreading logic in main.py uses a ThreadPoolExecutor to run both the FastAPI and Flask applications simultaneously

Identified Issues :
Some of the Issues I found were a Lack of Error Handling; resource management and also code readability.

Proposed Improvement:
These are the ways we can improve the multithreading function:
(1).implementing a try-except Error Handling
(2): Enhance Code Clarity

By addressing these issues and implementing the proposed improvements, the multithreading functionality in main.py can be made more robust, reliable, and maintainable. Please consider this issue for further discussion and contributions!

@devansh-shah-11
Copy link
Collaborator

Yep sure - go ahead and fix it up :)

@Kishore007raj
Copy link
Author

sure!!

@Devasy23 Devasy23 linked a pull request Oct 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants