Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify usage of CRS object #953

Open
Jaapel opened this issue May 24, 2024 · 1 comment
Open

Unify usage of CRS object #953

Jaapel opened this issue May 24, 2024 · 1 comment
Labels
Enhancement New feature or request Needs refinement issue still needs refinement V1

Comments

@Jaapel
Copy link
Contributor

Jaapel commented May 24, 2024

Kind of request

Changing existing functionality

Enhancement Description

Currently, crs in the code can be a str, int or pyproj.CRS object.
HydroMT should be flexible in parsing, but strict in internal code. This is not yet the case. We should use the same CRS object in all internals.

Use case

General Maintainance effort and readability of the code will benefit from these changes.

Additional Context

No response

@Jaapel Jaapel added Enhancement New feature or request Needs refinement issue still needs refinement V1 labels May 24, 2024
@Jaapel Jaapel added this to the v1.0 beta milestone May 24, 2024
@DirkEilander
Copy link
Contributor

DirkEilander commented May 27, 2024

We already tried to unify our internal representation of CRS a while back. Before we used by the rasterio and pyproj CRS objects interchangable, now internally all CRS objects are pyproj object right? Can you point to an example where you would like to see more additional changes?

@savente93 savente93 removed this from the v1.0 beta milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs refinement issue still needs refinement V1
Projects
None yet
Development

No branches or pull requests

3 participants