-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
res/resource.rc build error: windres.exe: unknown option -- W #8
Comments
Hi! I think this is caused by the "add_definitions" commands in the CMakeLists file. I'll fix this soon, I think I just need to replace these commands with CXX_FLAGS flags. Thank you again for finding another bug! |
@lopshopedun #10 should fix this bug, can you check before I merge it ? Thank you :) |
I've checked it. Yes, now the bug is fixed. Tests passed: Click to expand
Maybe create in the future CI/CD pipeline for building in Windows under GCC? |
Yes, I'll add that to the project's to-do list. Supporting more compilers in the CI/CD pipeline is definitely a must-have, and not a big thing. |
Describe the bug
/res/resource.rc
doesn't compiled due to wrongRC_FLAGS
cmake variableTo Reproduce
the same as in issue #6
Expected behavior
res/resource.rc should be compiled without error
Screenshots
rel_win_build\CMakeFiles\Degate.dir\flags.make:
rel_win_build\CMakeFiles\Degate.dir\build.make:
Environment:
the same as in issue #6
Additional context
I don't know why mingw GCC 8.x.y compiler set such
RC_FLAGS
value.If the line
RC_FLAGS = -Wall -g -fno-inline -std=c++11
is commented out manually, then Degate compiles successfully.I tried
set(CMAKE_RC_FLAGS "")
, but it doesn't help.Any ideas?
The text was updated successfully, but these errors were encountered: