Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native theme collor dosent match the windows one #32

Closed
drone84 opened this issue Aug 20, 2024 · 3 comments · Fixed by #33
Closed

Native theme collor dosent match the windows one #32

drone84 opened this issue Aug 20, 2024 · 3 comments · Fixed by #33
Assignees
@DorianBDev
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@drone84
Copy link

drone84 commented Aug 20, 2024

Right after a fresh install with the online installe the collor shem of the interface dosent match the one I have in windows. After cheking the preferance/apparance setting the theme mode is set as Native so the interface should be dark.
Manually sellecting dark work

Steps to reproduce the behavior:

  1. Have windows in dark them
  2. Install a fresh version with onlin install
  3. look at the them collor

Expected behavior
the collor them od Degate should be dark

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11 Pro
  • Version: 23H2
@DorianBDev
Copy link
Member

After checking the issue, I confirm the behavior. However, Qt doesn't support "native" dark theme for Windows. I can land a "fix" which will set dark theme by default on Windows if it detects dark theme at desktop level.

This will not land today since I need to rework the CI before being able to publish a new nightly version.

@DorianBDev DorianBDev added bug Something isn't working good first issue Good for newcomers labels Aug 20, 2024
DorianBDev added a commit that referenced this issue Aug 20, 2024
@DorianBDev
fix(#32): default dark theme on windows matching desktop
73c572b 
Qt doesn't select right theme that match desktop, and always select
native (light) on Windows. This add a new check to match dekstop
theme, on Windows only. Note that dark theme isn't native dark, but
since Qt doesn't offer one it should be ok.
@DorianBDev DorianBDev mentioned this issue Aug 20, 2024
Merged
7 tasks
@DorianBDev DorianBDev linked a pull request Aug 20, 2024 that will close this issue
fix(#32): default dark theme on windows matching desktop #33
Merged
7 tasks
DorianBDev added a commit that referenced this issue Aug 20, 2024
@DorianBDev
Merge pull request #33 from DegateCommunity/32-native-theme-collor-do…
0282e6c 
…sent-match-the-windows-one

fix(#32): default dark theme on windows matching desktop
@DorianBDev
Copy link
Member

After fixing the deploy CI I'll release a new nightly version (that'll feature a fix for this issue).

@DorianBDev
Copy link
Member

A fix landed in the new 2.1.0-beta.2 pre-release. Pre-built binaries are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DorianBDev DorianBDev

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#32): default dark theme on windows matching desktop DegateCommunity/Degate
2 participants
@DorianBDev @drone84