-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attached feature] Crash when handling large images (beta) #24
Comments
Hi! Thanks for this bug report. I think the issue comes from thread count exhaustion since Degate will try to load image chunks around each position, and at each zoom level. With a big image this might lag behind since loading takes time, and thread count might just explode and make Degate hang/crash. I'll try to address the issue by changing a bit the loading system, but that might take some time. A possible workaround before landing a fix could be to reduce some parameters to lower values in preferences. I'll try to add some status update soon. |
@dev-zzo Could you confirm that Degate was initially loading the image (you were able to see it), but after zooming multiple time it freezes and crash? |
With the 'attached' project type, that is the observed behaviour indeed. |
A small update on the issue: I might have found an algorithm that'll fix the problem. However it might take some time to experiment and find the best variant. I'll also add a visual indicator when a tile is loading, and make sure even under heavy load Degate will not crash/freeze (in worse case loading will just be very slow). I'm really busy for the end of the year, but I hope I'll land a fix (and new beta version) before the new year. |
I should have fixed the issue with 77631e1. I'll do more tests and a bit of cleanup before creating & merging a PR. I regret not having had more time before to tackle the issue (which did not take long to resolve). |
A fix landed in the new 2.1.0-beta.2 pre-release. Pre-built binaries are available. |
Describe the bug
Degate seems to be unable to handle large images in the latest version with the 'attached' project type.
To Reproduce
Steps to reproduce the behavior:
I also tested the half-sized image with the same result.
Expected behavior
There should be no crashing.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: