Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash while loading a JPEG image #2

Closed
DorianBDev opened this issue Feb 6, 2021 · 5 comments
Closed

Crash while loading a JPEG image #2

DorianBDev opened this issue Feb 6, 2021 · 5 comments
Assignees
@DorianBDev
Labels
bug Something isn't working

Comments

@DorianBDev
Copy link
Member

DorianBDev commented Feb 6, 2021 •
edited
Loading

Describe the bug
Crash while loading a JPEG image, reported by Yannick D. (via email). Need more information to investigate.
@DorianBDev DorianBDev added the bug Something isn't working label Feb 6, 2021
@DorianBDev DorianBDev self-assigned this Feb 6, 2021
@DorianBDev
Copy link
Member Author

No "error_log.txt" file generated (not good).

@DorianBDev
Copy link
Member Author

System
OS: Windows Windows 10 Pro 2004
Installation: Degate_binaries_Windows_x64

Steps to reproduce

  1. Create new project,
  2. Add new layer
  3. Import image

Additional information
Freeze with the "Importation and conversion of the new background image" dialog and then crash.

@DorianBDev
Copy link
Member Author

The issue is reproducible on my machine, good news.

@DorianBDev
Copy link
Member Author

The issue is that the JPEG image that the user was trying to load was a grayscale one (8-bit depth). The fix is simple, we just need to check the image format, and if not ARGB32 or RGB32, convert it.

DorianBDev added a commit that referenced this issue Feb 6, 2021
@DorianBDev
Fixed issue #2: 8-bit depth JPEG loading.
48b2392
@DorianBDev
Copy link
Member Author

Fixed with 48b2392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DorianBDev DorianBDev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorianBDev